Make commands configurable and add try:each command, soft-deprecating testall
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Can be specified top-level or per scenario as 'command' - Per scenario wins. - If the ember-try command allows specifying the command at runtime and that option is taken, that command wins. This config applies to `ember try` and `ember try:testall`, perhaps counterintuitively, but `ember try:testall` still defaults to running `ember test`. - New test helper to mock `run`. It has, perhaps, too much knowledge of internals, but is preferable to that knowledge being spread throughout the tests.
- Commands from configuration can now be used with `ember try`
- Does exact same as testall, but has a name that accomodates being able to configure commands
kategengler
added a commit
that referenced
this pull request
Feb 19, 2016
Make commands configurable and add `try:each` command, soft-deprecating `testall`
luxzeitlos
pushed a commit
to luxzeitlos/ember-try
that referenced
this pull request
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands can now be specified in configuration, both top-level and under each scenario.
New command
ember try:eachthat is an exact replacement forember try:testall, with a new name that better fits the ability to configure commands.ember try:testallstill works.Documentation commit coming soon.