Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli-table2 to cli-table3 #198

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 11, 2018

This PR updates the cli-table2 dependency to cli-table3, which fixes one of the npm audit warnings :)

cli-table2 (like cli-table itself) is no longer maintained. In jamestalmage/cli-table2#43 a couple of people have offered to take over maintenance but the current maintainer did not respond so as a result the project was forked to https://github.com/cli-table/cli-table3.

@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2018

Restarted a couple of the CI jobs...

@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2018

CI is failing due to Node 4 support

@Turbo87
Copy link
Member Author

Turbo87 commented Jun 11, 2018

ah, didn't know we still supported it here. should we drop it?

@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2018

Yes, we should drop Node 4 for 1.0.0

@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4f8b32a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #198   +/-   ##
=========================================
  Coverage          ?   95.92%           
=========================================
  Files             ?       16           
  Lines             ?      491           
  Branches          ?        0           
=========================================
  Hits              ?      471           
  Misses            ?       20           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8b32a...2817b04. Read the comment docs.

@Turbo87
Copy link
Member Author

Turbo87 commented Jun 12, 2018

@rwjblue I've downgraded to v0.4.0 for now which is still Node 4 compatible

@rwjblue
Copy link
Member

rwjblue commented Jun 12, 2018

Ok, seems fine here, but I do still want to drop Node 4 before releasing 1.0 final...

@Turbo87
Copy link
Member Author

Turbo87 commented Jun 12, 2018

I do still want to drop Node 4 before releasing 1.0 final

sure, just unrelated to this particular PR. we can bump to v0.5.0 afterwards.

@rwjblue rwjblue merged commit 39ede7d into ember-cli:master Jun 12, 2018
@Turbo87 Turbo87 deleted the cli-table branch June 12, 2018 11:52
@Turbo87
Copy link
Member Author

Turbo87 commented Sep 25, 2018

wow... can't believe I forgot to update the require() call in this PR 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants