-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli-table2
to cli-table3
#198
Conversation
Restarted a couple of the CI jobs... |
CI is failing due to Node 4 support |
ah, didn't know we still supported it here. should we drop it? |
Yes, we should drop Node 4 for 1.0.0 |
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=========================================
Coverage ? 95.92%
=========================================
Files ? 16
Lines ? 491
Branches ? 0
=========================================
Hits ? 471
Misses ? 20
Partials ? 0 Continue to review full report at Codecov.
|
@rwjblue I've downgraded to v0.4.0 for now which is still Node 4 compatible |
Ok, seems fine here, but I do still want to drop Node 4 before releasing 1.0 final... |
sure, just unrelated to this particular PR. we can bump to v0.5.0 afterwards. |
wow... can't believe I forgot to update the |
This PR updates the
cli-table2
dependency tocli-table3
, which fixes one of thenpm audit
warnings :)cli-table2
(likecli-table
itself) is no longer maintained. In jamestalmage/cli-table2#43 a couple of people have offered to take over maintenance but the current maintainer did not respond so as a result the project was forked to https://github.com/cli-table/cli-table3.