Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move requires from let -> const #194

Merged
merged 1 commit into from
May 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/commands/config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
let debug = require('debug')('ember-try:commands:config');

const debug = require('debug')('ember-try:commands:config');

module.exports = {
name: 'try:config',
Expand Down
2 changes: 1 addition & 1 deletion lib/commands/try-each.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
let debug = require('debug')('ember-try:commands:try-each');
const debug = require('debug')('ember-try:commands:try-each');

module.exports = {
name: 'try:each',
Expand Down
3 changes: 2 additions & 1 deletion lib/commands/try-ember.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
let debug = require('debug')('ember-try:commands:try-ember');

const debug = require('debug')('ember-try:commands:try-ember');

module.exports = {
name: 'try:ember',
Expand Down
5 changes: 3 additions & 2 deletions lib/commands/try-one.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';
let findByName = require('../utils/find-by-name');
let debug = require('debug')('ember-try:commands:try-one');

const findByName = require('../utils/find-by-name');
const debug = require('debug')('ember-try:commands:try-one');

module.exports = {
name: 'try:one',
Expand Down
18 changes: 9 additions & 9 deletions lib/dependency-manager-adapters/bower.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
'use strict';

let CoreObject = require('core-object');
let fs = require('fs-extra');
let RSVP = require('rsvp');
let path = require('path');
let extend = require('extend');
let debug = require('debug')('ember-try:dependency-manager-adapter:bower');
let rimraf = RSVP.denodeify(require('rimraf'));
let resolve = require('resolve');
let findEmberPath = require('../utils/find-ember-path');
const CoreObject = require('core-object');
const fs = require('fs-extra');
const RSVP = require('rsvp');
const path = require('path');
const extend = require('extend');
const debug = require('debug')('ember-try:dependency-manager-adapter:bower');
const rimraf = RSVP.denodeify(require('rimraf'));
const resolve = require('resolve');
const findEmberPath = require('../utils/find-ember-path');

module.exports = CoreObject.extend({
init() {
Expand Down
16 changes: 8 additions & 8 deletions lib/dependency-manager-adapters/npm.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
'use strict';

let CoreObject = require('core-object');
let fs = require('fs-extra');
let RSVP = require('rsvp');
let path = require('path');
let extend = require('extend');
let debug = require('debug')('ember-try:dependency-manager-adapter:npm');
let rimraf = RSVP.denodeify(require('rimraf'));
let chalk = require('chalk');
const CoreObject = require('core-object');
const fs = require('fs-extra');
const RSVP = require('rsvp');
const path = require('path');
const extend = require('extend');
const debug = require('debug')('ember-try:dependency-manager-adapter:npm');
const rimraf = RSVP.denodeify(require('rimraf'));
const chalk = require('chalk');

module.exports = CoreObject.extend({
init() {
Expand Down
9 changes: 5 additions & 4 deletions lib/tasks/reset.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
'use strict';
let CoreObject = require('core-object');
let debug = require('debug')('ember-try:commands:reset');
let ScenarioManager = require('../utils/scenario-manager');
let DependencyManagerAdapterFactory = require('./../utils/dependency-manager-adapter-factory');

const CoreObject = require('core-object');
const debug = require('debug')('ember-try:commands:reset');
const ScenarioManager = require('../utils/scenario-manager');
const DependencyManagerAdapterFactory = require('./../utils/dependency-manager-adapter-factory');

module.exports = CoreObject.extend({
run() {
Expand Down
13 changes: 7 additions & 6 deletions lib/tasks/try-each.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
'use strict';
let CoreObject = require('core-object');
let RSVP = require('rsvp');
let mapSeries = require('promise-map-series');
let chalk = require('chalk');
let debug = require('debug')('ember-try:task:try-each');
let runCommand = require('./../utils/run-command');

const CoreObject = require('core-object');
const RSVP = require('rsvp');
const mapSeries = require('promise-map-series');
const chalk = require('chalk');
const debug = require('debug')('ember-try:task:try-each');
const runCommand = require('./../utils/run-command');

module.exports = CoreObject.extend({
run(scenarios, options) {
Expand Down
16 changes: 8 additions & 8 deletions lib/utils/config.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
'use strict';

let path = require('path');
let fs = require('fs');
let extend = require('extend');
let RSVP = require('rsvp');
let findByName = require('./find-by-name');
let debug = require('debug')('ember-try:utils:config');

let IMPLICIT_BOWER_VERSION = '^1.8.2';
const path = require('path');
const fs = require('fs');
const extend = require('extend');
const RSVP = require('rsvp');
const findByName = require('./find-by-name');
const debug = require('debug')('ember-try:utils:config');

const IMPLICIT_BOWER_VERSION = '^1.8.2';

function getBaseConfig(options) {
let relativePath = options.configPath || path.join('config', 'ember-try.js');
Expand Down
4 changes: 2 additions & 2 deletions lib/utils/dependency-manager-adapter-factory.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

let BowerAdapter = require('../dependency-manager-adapters/bower');
let NpmAdapter = require('../dependency-manager-adapters/npm');
const BowerAdapter = require('../dependency-manager-adapters/bower');
const NpmAdapter = require('../dependency-manager-adapters/npm');

module.exports = {
generateFromConfig(config, root) {
Expand Down
6 changes: 3 additions & 3 deletions lib/utils/find-ember-path.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';

let path = require('path');
let RSVP = require('rsvp');
let resolve = RSVP.denodeify(require('resolve'));
const path = require('path');
const RSVP = require('rsvp');
const resolve = RSVP.denodeify(require('resolve'));

module.exports = function(root) {
/* Find ember-cli's entry point module relative to
Expand Down
6 changes: 3 additions & 3 deletions lib/utils/result-summary.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';

let CoreObject = require('core-object');
let chalk = require('chalk');
let Table = require('cli-table2');
const CoreObject = require('core-object');
const chalk = require('chalk');
const Table = require('cli-table2');

module.exports = CoreObject.extend({
print() {
Expand Down
8 changes: 4 additions & 4 deletions lib/utils/run-command.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict';

let RSVP = require('rsvp');
let extend = require('extend');
let findEmberPath = require('./find-ember-path');
let run = require('./run');
const RSVP = require('rsvp');
const extend = require('extend');
const findEmberPath = require('./find-ember-path');
const run = require('./run');

module.exports = function(root, commandArgs, opts) {
let options = extend({ cwd: root }, opts);
Expand Down
6 changes: 3 additions & 3 deletions lib/utils/scenario-manager.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';

let CoreObject = require('core-object');
let RSVP = require('rsvp');
let mapSeries = require('promise-map-series');
const CoreObject = require('core-object');
const RSVP = require('rsvp');
const mapSeries = require('promise-map-series');

module.exports = CoreObject.extend({
init() {
Expand Down
10 changes: 5 additions & 5 deletions test/commands/try-each-test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict';

let expect = require('chai').expect;
let RSVP = require('rsvp');
let TryEachCommand = require('../../lib/commands/try-each');
const expect = require('chai').expect;
const RSVP = require('rsvp');
const TryEachCommand = require('../../lib/commands/try-each');

let origTryEachTask = TryEachCommand._TryEachTask;
let origGetConfig = TryEachCommand._getConfig;
const origTryEachTask = TryEachCommand._TryEachTask;
const origGetConfig = TryEachCommand._getConfig;

describe('commands/try-each', () => {
describe('#run', () => {
Expand Down
10 changes: 5 additions & 5 deletions test/commands/try-ember-test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict';

let expect = require('chai').expect;
let RSVP = require('rsvp');
let TryEmberCommand = require('../../lib/commands/try-ember');
const expect = require('chai').expect;
const RSVP = require('rsvp');
const TryEmberCommand = require('../../lib/commands/try-ember');

let origTryEachTask = TryEmberCommand._TryEachTask;
let origGetConfig = TryEmberCommand._getConfig;
const origTryEachTask = TryEmberCommand._TryEachTask;
const origGetConfig = TryEmberCommand._getConfig;

describe('commands/try-ember', () => {
describe('#run', () => {
Expand Down
10 changes: 5 additions & 5 deletions test/commands/try-one-test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict';

let expect = require('chai').expect;
let RSVP = require('rsvp');
let TryOneCommand = require('../../lib/commands/try-one');
const expect = require('chai').expect;
const RSVP = require('rsvp');
const TryOneCommand = require('../../lib/commands/try-one');

let origTryEachTask = TryOneCommand._TryEachTask;
let origGetConfig = TryOneCommand._getConfig;
const origTryEachTask = TryOneCommand._TryEachTask;
const origGetConfig = TryOneCommand._getConfig;

describe('commands/try-one', () => {
describe('getCommand', () => {
Expand Down
2 changes: 1 addition & 1 deletion test/helpers/generate-mock-run.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

let extend = require('extend');
const extend = require('extend');

module.exports = function generateMockRun() {
let mockedRuns = [];
Expand Down
4 changes: 2 additions & 2 deletions test/helpers/stub-dependency-manager-adapter.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

let CoreObject = require('core-object');
let RSVP = require('rsvp');
const CoreObject = require('core-object');
const RSVP = require('rsvp');

module.exports = CoreObject.extend({
setup() {
Expand Down
2 changes: 1 addition & 1 deletion test/helpers/write-json-file.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

let fs = require('fs-extra');
const fs = require('fs-extra');

module.exports = function writeJSONFile(filename, contents) {
fs.writeFileSync(filename, JSON.stringify(contents, null, 2));
Expand Down
22 changes: 11 additions & 11 deletions test/tasks/reset-test.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
'use strict';

let tmp = require('tmp-sync');
let path = require('path');
let RSVP = require('rsvp');
let fs = require('fs-extra');
let fixtureBower = require('../fixtures/bower.json');
let writeJSONFile = require('../helpers/write-json-file');

let remove = RSVP.denodeify(fs.remove);
let root = process.cwd();
let tmproot = path.join(root, 'tmp');
let tmpdir;
const tmp = require('tmp-sync');
const path = require('path');
const RSVP = require('rsvp');
const fs = require('fs-extra');
const fixtureBower = require('../fixtures/bower.json');
const writeJSONFile = require('../helpers/write-json-file');

const remove = RSVP.denodeify(fs.remove);
const root = process.cwd();
const tmproot = path.join(root, 'tmp');

describe('reset', () => {
let tmpdir;
beforeEach(() => {
tmpdir = tmp.in(tmproot);
process.chdir(tmpdir);
Expand Down
33 changes: 17 additions & 16 deletions test/tasks/try-each-test.js
Original file line number Diff line number Diff line change
@@ -1,25 +1,24 @@
'use strict';

let expect = require('chai').expect;
let tmp = require('tmp-sync');
let path = require('path');
let RSVP = require('rsvp');
let fs = require('fs-extra');
let fixtureBower = require('../fixtures/bower.json');
let fixturePackage = require('../fixtures/package.json');
let writeJSONFile = require('../helpers/write-json-file');
let mockery = require('mockery');
const expect = require('chai').expect;
const tmp = require('tmp-sync');
const path = require('path');
const RSVP = require('rsvp');
const fs = require('fs-extra');
const fixtureBower = require('../fixtures/bower.json');
const fixturePackage = require('../fixtures/package.json');
const writeJSONFile = require('../helpers/write-json-file');
const mockery = require('mockery');

/* Some of the tests in this file intentionally DO NOT stub dependency manager adapter*/
let StubDependencyAdapter = require('../helpers/stub-dependency-manager-adapter');
let generateMockRun = require('../helpers/generate-mock-run');
const StubDependencyAdapter = require('../helpers/stub-dependency-manager-adapter');
const generateMockRun = require('../helpers/generate-mock-run');

let remove = RSVP.denodeify(fs.remove);
let root = process.cwd();
let tmproot = path.join(root, 'tmp');
let tmpdir;
const remove = RSVP.denodeify(fs.remove);
const root = process.cwd();
const tmproot = path.join(root, 'tmp');

let config = {
const config = {
scenarios: [
{
name: 'first',
Expand Down Expand Up @@ -69,6 +68,8 @@ let config = {
};

describe('tryEach', () => {
let tmpdir;

beforeEach(() => {
tmpdir = tmp.in(tmproot);
process.chdir(tmpdir);
Expand Down
28 changes: 14 additions & 14 deletions test/utils/config-test.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
'use strict';

let expect = require('chai').expect;
let RSVP = require('rsvp');
let fs = require('fs-extra');
let path = require('path');
let tmp = require('tmp-sync');
let fixturePackage = require('../fixtures/package.json');
let writeJSONFile = require('../helpers/write-json-file');
let getConfig = require('../../lib/utils/config');
let addImplicitBowerToScenarios = getConfig._addImplicitBowerToScenarios;

let remove = RSVP.denodeify(fs.remove);
let root = process.cwd();
let tmproot = path.join(root, 'tmp');
let tmpdir;
const expect = require('chai').expect;
const RSVP = require('rsvp');
const fs = require('fs-extra');
const path = require('path');
const tmp = require('tmp-sync');
const fixturePackage = require('../fixtures/package.json');
const writeJSONFile = require('../helpers/write-json-file');
const getConfig = require('../../lib/utils/config');
const addImplicitBowerToScenarios = getConfig._addImplicitBowerToScenarios;

const remove = RSVP.denodeify(fs.remove);
const root = process.cwd();
const tmproot = path.join(root, 'tmp');

describe('utils/config', () => {
let project;
let tmpdir;

beforeEach(() => {
tmpdir = tmp.in(tmproot);
Expand Down
4 changes: 2 additions & 2 deletions test/utils/dependency-manager-adapter-factory-test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

let expect = require('chai').expect;
let DependencyManagerAdapterFactory = require('../../lib/utils/dependency-manager-adapter-factory');
const expect = require('chai').expect;
const DependencyManagerAdapterFactory = require('../../lib/utils/dependency-manager-adapter-factory');

describe('DependencyManagerAdapterFactory', () => {
describe('generateFromConfig', () => {
Expand Down
Loading