Added an option to --skip-cleanup #18
Conversation
| var promise; | ||
| if(commandOptions.skipCleanup){ | ||
| //create a fake promise for consistency | ||
| promise = new RSVP.Promise(function(resolve) { |
There was a problem hiding this comment.
Can just be promise = RSVP.Promise.resolve();.
|
Thanks @rwjblue I knew there was a better way to do that, but my google-foo failed me. |
|
Thanks @jrjohnson. I think something we should warn about: If you use this option and, without cleaning up, build and deploy as the result of a passing test suite, it will build with the last set of dependencies I think it would make sense for |
|
@kategengler - where should I put the warning? In the README, as output after the command is run, or in the command options itself? |
|
The README would be good, thanks. On Thu, Apr 9, 2015 at 4:01 AM, Jonathan Johnson [email protected]
|
|
Updated the README with @kategengler's warning, added --skip-cleanup to testall, and fixed my original code to not pass that option on to ember. Let me know if you want me to squash all these commits, I left them separate so they were easier to review. |
|
Looks good, it'd be great if you could squash. |
try and try:testall commands now have an option to --skip-cleanup which prevents bower from being restored to its default state. This is usefull in CI environments where the code is being thrown out and not deployed.
jrjohnson
force-pushed
the
skipcleanupoption
branch
from
d0bf0f5 to
177a3c3
Compare
|
ok, all set. |
Added an option to --skip-cleanup
When running in a CI environment like travis the cleanup is just extra
time wasted. —skip-cleanup will prevent the reset from running.
I only added this to the try command, if you want I’m happy to add it to testall as well, but I'm not sure if that has the same use case.
I did a thing with a fake promise in the try task that might be the wrong approach, but I'm not super familiar with writing commands and I wasn't sure what needed to be returned from where. Alternatively I could skip the promise and just exit, but then the output would have to be managed in two places.
All that is to say - let me know if you want me to do this another way.