Allow additional matchers to be added without monkey patching prototype. #14
Conversation
|
Submitted ember-cli/ember-cli-qunit#77 to use this API. |
| @@ -53,9 +82,14 @@ define("ember-cli/test-loader", | |||
| new TestLoader().loadModules(); | |||
| }; | |||
|
|
|||
| TestLoader.addModuleIncludeMatcher = addModuleIncludeMatcher; | |||
There was a problem hiding this comment.
I see you expose the add functions in 2 different ways by both adding them to the TestLoader function here, as well as returning the function directly in the return object below (90-91). I'm ok with it, but just curious why both were done.
There was a problem hiding this comment.
I guess adding it to TestLoader will save us a line of code on the other end, instead of setting the function to a separate variable off the module, we can just invoke it directly on TestLoader. (I'm talking about the other pull request: https://github.com/ember-cli/ember-cli-qunit/pull/77/files line 6 and 12-13). Not a big deal at all though.
There was a problem hiding this comment.
Nah, I went the other way. Modules 4 LYFE!
Currently, `TestLoader.prototype.shouldLoadModule` is monkey patched by ember-cli-qunit / ember-cli-mocha to add their own custom rules for matching modules. This change allows additional addons to add their own custom matchers (for example adding additional extension types) or to suppress a certain subset of modules (for example JSHint or JSCS tests).
rwjblue
force-pushed
the
allow-additional-matchers
branch
from
ba78280 to
eecfbc1
Compare
|
🚢shipit, thx for cranking this out |
Allow additional matchers to be added without monkey patching prototype.
Currently,
TestLoader.prototype.shouldLoadModuleis monkey patched by ember-cli-qunit / ember-cli-mocha to add their own custom rules for matching modules.This change allows additional addons to add their own custom matchers (for example adding additional extension types) or to suppress a certain subset of modules (for example JSHint or JSCS tests).