Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @ember/string (it's unused) #197

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Remove @ember/string (it's unused) #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48a3d63
Remove @ember/string (it's unused)
NullVoxPopuli Aug 21, 2024
5b0dfbe
Configure the package.json to provide hints for local tooling
NullVoxPopuli Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
},
"dependencies": {
"@babel/core": "^7.23.2",
"@ember/string": "^3.0.0",
"ember-cli-babel": "^8.2.0"
},
"devDependencies": {
Expand Down Expand Up @@ -101,5 +100,10 @@
"ember-addon": {
"configPath": "tests/dummy/config",
"after": "ember-cli-htmlbars"
},
"packageManager": "[email protected]",
"volta": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're adding volta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it only matters for folks who have volta installed locally, and affects no one and nothing else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set the tool versions to what CI is using

"node": "16.20.2",
"pnpm": "8.15.9"
}
}
56 changes: 44 additions & 12 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.