Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move blueprint-test to node-tests folder #4

Closed
4 of 5 tasks
trabus opened this issue Dec 15, 2015 · 7 comments
Closed
4 of 5 tasks

Move blueprint-test to node-tests folder #4

trabus opened this issue Dec 15, 2015 · 7 comments

Comments

@trabus
Copy link
Contributor

trabus commented Dec 15, 2015

To go with a more consistent structure for the tests, we should move the generated blueprint-nodetest.js in the blueprint-test blueprint to the node-tests folder.

  • create node-tests folder in blueprint-test blueprint files
  • change naming scheme from blueprint-nodetest.js to [blueprintname]-test.js
  • change .npmignore to ignore node-tests folder
  • change test runner to look into node-tests folder instead of looking for -nodetest
  • move blueprint-tests in ember-cli-legacy-blueprints to node-tests folder
@trabus trabus closed this as completed in 8094248 Dec 16, 2015
rwjblue added a commit that referenced this issue Dec 16, 2015
Fixes #4 move tests to node-tests folder
@rwjblue rwjblue reopened this Dec 16, 2015
@rwjblue
Copy link
Member

rwjblue commented Dec 16, 2015

Reopened for the last item on the checklist (moving the files around in ember-cli-legacy-blueprints).

@trabus
Copy link
Contributor Author

trabus commented Dec 16, 2015

Working on that now. Thanks for reopening.

@trabus
Copy link
Contributor Author

trabus commented Dec 16, 2015

I have one more change, the blueprint tests were being generated in node-tests/blueprints/blueprintname/blueprintname-test.js, I'm moving it to node-tests/blueprints/blueprintname-test.js.

@trabus
Copy link
Contributor Author

trabus commented Dec 16, 2015

@rwjblue One thing I've found a bit annoying is blueprints with -test become -test-test, but it's only a minor annoyance.

@rwjblue
Copy link
Member

rwjblue commented Dec 16, 2015

LOL, that is kinda funny, but I think in its own way it makes sense...

@Turbo87
Copy link
Member

Turbo87 commented Mar 4, 2016

@trabus I think since the test blueprints are also tested by the main blueprints we can just move the test blueprint tests into the main blueprint tests file.

@Turbo87
Copy link
Member

Turbo87 commented Mar 13, 2016

closing this in favor of ember-cli/ember-cli-legacy-blueprints#2

@Turbo87 Turbo87 closed this as completed Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants