This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Use Ember.assign() if possible
#93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -200,8 +200,8 @@ export default class AjaxRequest { | |||
| */ | |||
| _getFullHeadersHash(headers) { | |||
| const classHeaders = get(this, 'headers') || {}; | |||
| const _headers = merge({}, classHeaders); | |||
| return merge(_headers, headers); | |||
| const _headers = assign({}, classHeaders); | |||
There was a problem hiding this comment.
assign allows more than two arguments so we should be able to do this in a single invocation:
return assign({}, classHeaders, headers);There was a problem hiding this comment.
Ahh, but we can't do that until we can require v2.5.0, 😿
There was a problem hiding this comment.
@rwjblue yep, assign could be Ember.merge. 
|
This LGTM |
|
Hmm, @Cryrivers CI doesn't seem very happy with the change, but it looks good to me once that is settled. |
|
@alexlafroscia not sure why those 5 test cases failed 😢 |
|
Looks like the deprecation has been removed: emberjs/ember.js#13344 |
|
Yeah, in light of that fact, I'm going to close this. Thanks for the PR though, @Cryrivers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
Ember.mergeis deprecated sinceEmber 2.5.0