breaking(plugin): stop adding the decorators option into Babel plugin
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the most recent versions of `ember-cli-babel` we started including the legacy decorators transform by default. When used with this plugin, this causes breakage, because both plugins are adding _conflicting_ internal babel plugins. In general, this is problematic, because the `filter-imports` plugin is making assumptions about which version of decorators will be used. It would instead make more sense to allow the user to choose which version they want by adding and configuring the `@babel/plugin-proposal-decorators` package themselves. This PR removes the plugin, and adds the proposal package for local testing. Users of the package _should_ already be required to add the decorators transform if they are filtering decorators, so this shouldn't be an issue in general, but this is _technically_ breaking so I think it would make sense to bump a major version.
|
@pzuraq - Looks like this needs a rebase... |
layershifter
changed the title
decorators Babel plugindecorators option into Babel plugin
|
❤️ ❤️ ❤️ |
|
Was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the most recent versions of
ember-cli-babelwe started includingthe legacy decorators transform by default. When used with this plugin,
this causes breakage, because both plugins are adding conflicting
internal babel plugins.
In general, this is problematic, because the
filter-importsplugin ismaking assumptions about which version of decorators will be used. It
would instead make more sense to allow the user to choose which version
they want by adding and configuring the
@babel/plugin-proposal-decoratorspackage themselves.This PR removes the plugin, and adds the proposal package for local
testing. Users of the package should already be required to add the
decorators transform if they are filtering decorators, so this shouldn't
be an issue in general, but this is technically breaking so I think it
would make sense to bump a major version.