Remove validation check for deprecation until
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This transform currently verifies that `deprecate()` has a meta object with `id` and `until`. This info is helpful, but there are potential cases where the `until` may not be known, but we still want this stripping functionality. For instance, we're planning on adding `deprecate` to Glimmer VM. We still want the VM to be able to strip out these `deprecate` calls, but the VM ultimately isn't responsible for determining the major versions when the feature will be removed - that's up to the host environment. The plan is to have the host environment add `until` dynamically. I believe `id` is the only bit of metadata that is universal, so I decided to keep it.d
rwjblue
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transform currently verifies that
deprecate()has a meta objectwith
idanduntil. This info is helpful, but there are potentialcases where the
untilmay not be known, but we still want thisstripping functionality.
For instance, we're planning on adding
deprecateto Glimmer VM. Westill want the VM to be able to strip out these
deprecatecalls, butthe VM ultimately isn't responsible for determining the major versions
when the feature will be removed - that's up to the host environment.
The plan is to have the host environment add
untildynamically.I believe
idis the only bit of metadata that is universal, so Idecided to keep it.d