Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from beta to final babel 7 #75

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Update from beta to final babel 7 #75

merged 1 commit into from
Dec 21, 2018

Conversation

jrjohnson
Copy link
Contributor

Trying to remove the message:

warning "@ember/jquery > ember-cli-babel > [email protected]" has unmet peer dependency "@babel/core@^7.0.0-beta.42"

from my ember app. Seemed easy enough that I could file a PR instead of an issue, but I might not have any idea what I'm doing here 😛

rwjblue
rwjblue approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, but unfortunately I don't believe that this alone will fix the warnings you are seeing.

@rwjblue
Copy link
Member

rwjblue commented Dec 7, 2018

Ugh, will need a breaking change PR to drop Node 4 it looks like 😭

@jrjohnson jrjohnson mentioned this pull request Dec 20, 2018
Merged
@rwjblue
Copy link
Member

rwjblue commented Dec 21, 2018

Ok, I think this should be passing with a rebase

@jrjohnson
Copy link
Contributor Author

Rebased and indeed passing.

Turbo87
Turbo87 approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙏

@Turbo87 Turbo87 merged commit ad2d7fd into ember-cli:master Dec 21, 2018
@jrjohnson jrjohnson deleted the update-babel branch December 21, 2018 16:52
@jrjohnson
Copy link
Contributor Author

Just a friendly bump on this, would love to see it in a release (though I know the breaking against a 0.2.0 is probably a bit fraught).

@Turbo87
Copy link
Member

Turbo87 commented Jan 29, 2019

@jrjohnson released as v0.3.0 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrjohnson @rwjblue @Turbo87