-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove imports without specifiers #69
Conversation
Does the issue not affect the master branch? |
Probably, but the only version that showed up in my dependency tree was the 0.1.x series. I don't know the state of the betas, so it makes sense to fix it in stable to me. |
I'm trying to understand what is going on here. Does this mean you can't use imports that have side effects? If so then unclear how things like this would work. https://github.com/glimmerjs/glimmer-vm/blob/master/packages/%40glimmer/runtime/lib/bootstrap.ts |
No, it just means this plugin is not doing a complete job of stripping out these debug shim modules. |
Ah seems good. Any possibility you can rebase? |
Rebasing to master wouldn't really be what I want, because everyone is using the 0.1.x release. |
We should fix in master then backport as needed. There is no fundamental reason that we can't update ember-cli-babel to use the latest (current beta) version. Just hasn't been done yet... |
4409421
to
2cf1c63
Compare
Here is the fix applied to master first. |
Closes #68. I branched off the latest stable tag. Can you push a 0.1.x branch so I can target that instead?