Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove imports without specifiers #69

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

kellyselden
Copy link
Member

@kellyselden kellyselden commented Jun 19, 2018

Closes #68. I branched off the latest stable tag. Can you push a 0.1.x branch so I can target that instead?

@rwjblue
Copy link
Member

rwjblue commented Jun 25, 2018

Does the issue not affect the master branch?

@kellyselden
Copy link
Member Author

Probably, but the only version that showed up in my dependency tree was the 0.1.x series. I don't know the state of the betas, so it makes sense to fix it in stable to me.

@chadhietala
Copy link
Member

I'm trying to understand what is going on here. Does this mean you can't use imports that have side effects? If so then unclear how things like this would work. https://github.com/glimmerjs/glimmer-vm/blob/master/packages/%40glimmer/runtime/lib/bootstrap.ts

@kellyselden
Copy link
Member Author

No, it just means this plugin is not doing a complete job of stripping out these debug shim modules.

@chadhietala
Copy link
Member

Ah seems good. Any possibility you can rebase?

@kellyselden
Copy link
Member Author

I branched off the latest stable tag. Can you push a 0.1.x branch so I can target that instead?

Rebasing to master wouldn't really be what I want, because everyone is using the 0.1.x release.

@rwjblue
Copy link
Member

rwjblue commented Jul 9, 2018

We should fix in master then backport as needed. There is no fundamental reason that we can't update ember-cli-babel to use the latest (current beta) version. Just hasn't been done yet...

@kellyselden
Copy link
Member Author

Here is the fix applied to master first.

@chadhietala chadhietala merged commit 7872467 into ember-cli:master Jul 17, 2018
@kellyselden kellyselden deleted the remove_blank branch July 17, 2018 08:40
@Turbo87 Turbo87 added the bug label Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants