Remove error throwing for svelte guarded features. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the error is error prone due to the ability to include arbitrary JS in conditionals, and provides a false sense of security due to the fact that a deprecated feature flag could be used in many locations other than a conditional. This changes the strategy for svelte features to: * **always** replace the imported deprecated flag with its boolean value * **never** add an arbitrary error * **always** remove feature source import statements that have no specifiers (previously only done in prod builds)
krisselden
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the error is error prone due to the ability to include arbitrary JS in conditionals, and provides a false sense of security due to the fact that a deprecated feature flag could be used in many locations other than a conditional.
This changes the strategy for svelte features to: