Remove the macro-getter

[NullVoxPopuli]

Potential solution for #594

[SergeAstapov]

@NullVoxPopuli yeah, I've tried this some time ago in #455 but those macros don't work as template helpers. Wasn't able to look up the root cause

[NullVoxPopuli]

it looks like you removed @embroider/macros. that's what provides the transforms 😅

[SergeAstapov]

@NullVoxPopuli I've updated #455 to not remove @embroider/macros from deps and still get Error: Attempted to resolve macroCondition, which was expected to be a helper, but nothing was found.

[NullVoxPopuli]

that means its making it to runtime -- it's supposed to be compiled away before the app boots. 🤔

[SergeAstapov]

that means its making it to runtime -- it's supposed to be compiled away before the app boots. 🤔

right, but it's responsibility of @embroider/macros in the context of host app to compile it away... hence I doubt if it's an issue in this lib.

[NullVoxPopuli]

could still be both. right now we don't have buildtime dead-branch elimination due to the usage of the getter (unless macros is smart enough to analyze backing JS of co-located components)

[mike-engel]

Potential alt for this in #647.

I'm having a heck of a time testing this in our app though, which uses npm instead of pnpm. If I take the build output of this and put it in node_modules/ember-animated/dist/components/animated-container.js though, I'm still getting the error:

ERROR in ../../ember-animated/dist/components/animated-container.js 13:0-58
Module not found: Error: Can't resolve './helpers/-element' in '/Users/mike/projects/ui/node_modules/.embroider/rewritten-app'
resolve './helpers/-element' in '/Users/mike/projects/ui/node_modules/.embroider/rewritten-app'
  using description file: /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
    using description file: /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/package.json (relative path: ./helpers/-element)
      no extension
        Field 'browser' doesn't contain a valid alias configuration
        /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/helpers/-element doesn't exist
      .wasm
        Field 'browser' doesn't contain a valid alias configuration
        /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/helpers/-element.wasm doesn't exist
      .mjs
        Field 'browser' doesn't contain a valid alias configuration
        /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/helpers/-element.mjs doesn't exist
      .js
        Field 'browser' doesn't contain a valid alias configuration
        /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/helpers/-element.js doesn't exist
      .json
        Field 'browser' doesn't contain a valid alias configuration
        /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/helpers/-element.json doesn't exist
      .ts
        Field 'browser' doesn't contain a valid alias configuration
        /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/helpers/-element.ts doesn't exist
      .hbs
        Field 'browser' doesn't contain a valid alias configuration
        /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/helpers/-element.hbs doesn't exist
      .hbs.js
        Field 'browser' doesn't contain a valid alias configuration
        /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/helpers/-element.hbs.js doesn't exist
      as directory
        /Users/mike/projects/ui/node_modules/.embroider/rewritten-app/helpers/-element doesn't exist
 @ ../../ember-animated/dist/_app_/components/animated-container.js 1:0-71 1:0-71
 @ ./pods/authenticated/post-registration/template.hbs 2:0-81 72:33-51
 @ ./assets/cio.js 3610:13-77

I have no idea why it's not stripping it out during the build. Is there some flag I need to enable? Is this a bug with @embroider/macros?