Adjusting time of data gathering in middleware reporter

addon-test-support/setup-middleware-reporter.ts

@@ -23,17 +23,26 @@ export const TEST_SUITE_RESULTS: AxeTestResult[] = [];
 
 let currentTestResult: AxeTestResult | undefined = undefined;
 let currentViolationsMap: Map<string, Result> | undefined = undefined;
-let currentUrls = new Set<string>();
-let currentRouteNames = new Set<string>();
+let currentUrls: Set<string> | undefined;
+let currentRouteNames: Set<string> | undefined;
+let currentTestHelpers: Set<string> | undefined;
 
+/**
+ * A custom reporter that is invoke once per failed a11yAudit call. This can be called
+ * multiple times per test, and the results are accumulated until testDone.
+ *
+ * @param axeResults The axe results for each a11yAudit.
+ * @returns Early returns if no violations are found.
+ */
 export async function middlewareReporter(axeResults: AxeResults) {
   if (axeResults.violations.length === 0) {
     return;
   }
 
+  let testMetaData = getTestMetadata(getContext());
+
   if (!currentTestResult) {
     let { module, testName } = QUnit.config.current;
-    let testMetaData = getTestMetadata(getContext());
 
     let stack = (!DEBUG && new Error().stack) || '';
 
@@ -42,16 +51,23 @@ export async function middlewareReporter(axeResults: AxeResults) {
       testName,
       urls: [],
       routes: [],
-      helpers: testMetaData.usedHelpers,
+      helpers: [],
       stack,
       violations: [],
     };
 
     currentViolationsMap = new Map();
+    currentUrls = new Set();
+    currentRouteNames = new Set();
+    currentTestHelpers = new Set();
   }
 
-  currentUrls.add(currentURL());
-  currentRouteNames.add(currentRouteName());
+  currentTestHelpers = new Set([
+    ...currentTestHelpers!.values(),
+    ...testMetaData.usedHelpers,
+  ]);
+  currentUrls!.add(currentURL());
+  currentRouteNames!.add(currentRouteName());
 
   axeResults.violations.forEach((violation) => {
     let rule = currentViolationsMap!.get(violation.id);
@@ -64,15 +80,24 @@ export async function middlewareReporter(axeResults: AxeResults) {
   });
 }
 
+/**
+ * Invoked once per test. Accumulates the results into a set of results used for
+ * reporting via the middleware reporter.
+ */
 export function pushTestResult() {
   if (typeof currentTestResult !== 'undefined') {
     currentTestResult.violations = [...currentViolationsMap!.values()];
-    currentTestResult.urls = [...currentUrls.values()];
-    currentTestResult.routes = [...currentRouteNames.values()];
+    currentTestResult.urls = [...currentUrls!.values()];
+    currentTestResult.routes = [...currentRouteNames!.values()];
+    currentTestResult.helpers = [...currentTestHelpers!.values()];
+
     TEST_SUITE_RESULTS.push(currentTestResult);
 
     currentTestResult = undefined;
     currentViolationsMap = undefined;
+    currentUrls = undefined;
+    currentRouteNames = undefined;
+    currentTestHelpers = undefined;
   }
 }