-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade ember cli to 3.8 LTS #120
Conversation
upgrade deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delays here @EndangeredMassa. I did a quick pass after reviewing the CI failures with some inline suggestions. There is one that will require a bit more hand tweaking on your end (the "in a jQuery context" test), but I tried to explain what needed to change.
I think that with these changes, CI should pass...
I'm going to commit these suggested changes- we can roll back if we need to. Co-Authored-By: MelSumner <[email protected]>
Co-Authored-By: MelSumner <[email protected]>
Co-Authored-By: MelSumner <[email protected]>
Co-Authored-By: MelSumner <[email protected]>
Co-Authored-By: MelSumner <[email protected]>
updating README to fix incorrect links
…11y/ember-a11y-testing into smassa/upgrade-ember-cli
@EndangeredMassa I updated to 3.8 which is now latest LTS |
after merging this, we'll need to do a major version bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this branch so it uses 3.8 LTS instead of 3.4, updated ember-try and travis config, and added the jQuery check that @rwjblue suggested. Thank you for working on this, @EndangeredMassa !
@rwjblue do you think this is okay to merge now? |
These changes are preventing #123 from moving forward. I don't have full context, but @MelSumner, @EndangeredMassa, is this stable to merge with the main branch? |
@MelSumner @EndangeredMassa @drewlee created #138 with upgrade to 3.12. Happy to help push it over the line |
I used
ember-cli-update
(and manual changes) to upgrade this repo to ember-cli 3.4, which is the most recent LTS release.The test suite still passes locally and I manually linked this to a local app, which also still worked.
We still need to: