Refactor PBufWrapper #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBuf reference counting is done inside LwIP. PBufWrapper should be transparent implementation without intrusive reference counting. This commit makes `PBufWrapper` class movable and non-copyable. Signed-off-by: Alexander Livenets <[email protected]>
apexai-alex
force-pushed
the
refactor/pbufwrapper
branch
from
c7ec6a0 to
a1de467
Compare
|
Merged with PR #28 The branch containing the latest changes was actually feature/discovery_rework, not stabil. Sorry for the confusion. Your change also required additional API in the CacheChange class, see 50a2f10 I've briefly tested this on an STM32 in combination with FastDDS v2.11.2, since I currently don't have proper access to an ARM R5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBuf reference counting is done inside LwIP. PBufWrapper should be transparent implementation without intrusive reference counting. This commit makes
PBufWrapperclass movable and non-copyable.