Restore the GattData::process public API #311
Merged
+51
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivmarkov
force-pushed
the
restore-gattdata-process
branch
from
5d716e2 to
22dd85b
Compare
ivmarkov
force-pushed
the
restore-gattdata-process
branch
from
22dd85b to
19a68aa
Compare
|
/test |
|
@lulf Seems me issuing |
|
/test |
|
@ivmarkov Since this is running on my personal hardware, the command will only work for members with write access. I've sent you an invite now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the Embassy Matrix chat, having a public
GattData::processAPI allows for "mixed-processing" scenarios, where the ATT PDUs are pulled using the "raw" ATTConnectiontype - yet - some of those PDUs are delegated to (an) attribute server viaGattData::process, while others are processed at the ATT PDU level.This is precisely what the Matter BTP implementation over trouble does here.
(This API was retired by GIT commit cb8985e#diff-27c58f7be9fbba9f7582453b30b6cde8d67e41414fe9004daea290d4c87da375 and I'm just restoring it here, except based on
DynamicAttributeServernow, as that's what the newGattConnectionhas and needs.)===
Additionally, I've addressed two hygienic issues in the
#[gatt_server]proc-macro, where an unqualifiedErrortype was used which was clashing with whatever the user had imported in terms ofErrorand which furthermore required the user to explicitly importtrouble_host::Errorwhich is NOK.===
Will un-draft once I test it a bit and confirm it works.