fix: BufferedUartRx embedded_hal_nb::serial::Read impl #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
reviewed
Feb 24, 2025
| Ok(data) | ||
| } else { | ||
| if state.rx_buf.is_full() { | ||
| self.info.interrupt.pend(); |
There was a problem hiding this comment.
why pend if full? this would create an interrupt storm.
it should be the other way: in the Ok branch, if the ringbuffer was full and thanks to this read it stops being full we have to pend the irq to kickstart reading bytes again.
embassy/embassy-stm32/src/usart/buffered.rs
Lines 617 to 621 in c52f567
There was a problem hiding this comment.
Yes you are right, I fixed it. The rx_buf full check is done before marking the byte as read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issue: #3883
The function was tested and works as expected (in our case at least)