Disable clippy error around generated main function #3850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of

embassy_executor::main
and generated code causesclippy
to complain even when using an empty function (for demonstration purposes).Currently the only way to make said error/warning go away is to put
#![allow(clippy::future_not_send)]
at the top of the module calling
embassy_executor::main
.Users unfortunately can't put the
allow
attribute like this (attribute gets removed during expansion).nor
Adding the attribute directly in the expanded code makes
clippy
happy.Note: This might not be the ideal fix (maybe allowing
async fn main(_spawner: SendSpawner) {}
would work but I don't have enough knowledge on embassy to know if that's faceable or wished).Adding the attribute seems like a good compromise, being quick and easy to maintain (maybe using
expect
can be better but it requires a relatively new version of rust)