Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using full remote path for tramp (fix #2251) #2253

Closed
wants to merge 3 commits into from
Closed

Using full remote path for tramp (fix #2251) #2253

wants to merge 3 commits into from

Conversation

FelipeLema
Copy link
Contributor

Make "using a full path on remote hosts" consistent (by always providing tramp prefix).

I didn't find any tramp-related unit tests, so I didn't add any. Let me know if they should be added.

When using a full path for a Language Server (like
`/ssh:remotehost/home/me/bin/pyls`), this will handle the remote
location correctly.

Previously, the command was passed with remote/tramp prefix, but on
the remote machine, an error would happen because
`/ssh:remotehost/home/me/bin/pyls` is not a real file that exists there.
@FelipeLema FelipeLema marked this pull request as draft October 15, 2020 13:38
@FelipeLema
Copy link
Contributor Author

I'm not getting this to work consistently, so I'm currently checking out what's missing

@FelipeLema
Copy link
Contributor Author

FelipeLema commented Oct 19, 2020

I don't know why, but lsp won't connect unless lsp-log-io has been set to non-nil value once. Like
1- boot up lsp
2- lsp will keep waiting for start
3- clangd reports JSON parse error: [3:2077, byte=2079]: Expected , or } after object property

I'll repeat 1-3 indefinitely. Now, if I set lsp-log-io to t, then
1- boot up lsp
2- connects correctly to clangd
And will keep doing it so correctly ever after... regardless of further values of lsp-log-io

I don't know if this is related to my change... will be researching.

@FelipeLema
Copy link
Contributor Author

May be related: #1845

@FelipeLema
Copy link
Contributor Author

closing because is out-of-place

see #2251 (comment)

@FelipeLema FelipeLema closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant