Optionally load evil-integration.el

[edkolev]

This is a WIP PR as a result of #992

I haven't self-tested thoroughly yet. Plus, there's an issue with the generation of .depend which is currently worked-around like so:

(when evil-want-integration
;; TODO creating the .depend file breaks if the following require is
;; not on a line of its own
(require 'evil-integration)
)

Edit: the workaround is is now removed.

Any suggestions for improvements are welcome.

[noctuid]

I think that it would be much preferable to split the files into one with keybindings and one with everything else (or to further split everything else, but I think the main thing most people would want to disable is only the keybindings). See my comment in #992. I don't think everyone would agree on what is "basic" (for example, I'd include the advice and setting of evil command properties).

[wasamasa]

Sigh. I don't want to split up anything at all.

[VanLaser]

For one, yes, I'd like evil not to load these keybindings by default, so I'd welcome a split too. Right now I have to use (are these easy to find for an evil newcomer? I think no):

  ;; don't let modes override any states (!)
  (setq evil-overriding-maps nil
        evil-intercept-maps nil
        evil-pending-intercept-maps nil
        evil-pending-overriding-maps nil)
  ;; subvert evil-operation.el overrides (dired, ibuffer etc.)
  (advice-add 'evil-make-overriding-map :override #'ignore)
  (advice-add 'evil-make-intercept-map  :override #'ignore)
  (advice-add 'evil-add-hjkl-bindings   :override #'ignore)

... so it would be much more "natural" to not have to apply such workarounds.

[TheBB]

I'm fine making evil-integration optional. Strongly agree with @wasamasa, let's not split it.

[noctuid]

Providing a setting to not load evil-integration without splitting it doesn't really solve anything. Users still have to require it for the configuration they want and use workarounds to prevent/undo the keybindings/overriding maps parts. That or they have to not load it all (now with an official setting) and copy the other parts into their own config or a new package. Nothing really changes.

Why don't you want to split it?

[wasamasa]

See the linked ticket.

[edkolev]

OK, this PR is now modified - it only adds the option to load evil-integration.el optionally. The generation of the .depend file is also tweaked.

[wasamasa]

This seems somewhat broad, can't you just allow leading space in front of (require 'evil-...)?

[edkolev]

Sure, the commit is now amended - only spaces are allowed in front on the (require ...

[wasamasa]

Thanks!