Fix a couple of linting issues #35
Conversation
|
Oops, missed a couple, hold on. |
|
Ok, good to go. |
|
I'm curious about the keyword replacements? Would adding (vs. replacing) extra keywords have fixed the linting issues? |
|
Indeed, my bad. I'll update it. |
|
Thanks! Nice, one step closer towards Melpa. |
| @@ -106,7 +106,7 @@ | |||
| (kbd "<down-mouse-1>") 'pdf-view-mouse-set-region | |||
|
|
|||
| (kbd "C-c C-c") 'docview-mode | |||
| (kbd "C-c <tab>") 'pdf-view-extract-region-image | |||
| [?\C-c tab] 'pdf-view-extract-region-image ; workaround package-lint bug | |||
There was a problem hiding this comment.
I don't think we should go down the route of twisting the code to make package-lint happy. package-lint is a helper, it has false positives and it's fine: we should not make the code uglier just for the sake of it.
There was a problem hiding this comment.
This crashed package-lint, and it would not continue it's analysis without the fix. This is not about silencing false positives.
There was a problem hiding this comment.
OK, but it is still just a helper. If the helper has an issue, it should not change our code which is fine.
Is the issue reported upstream?
There was a problem hiding this comment.
Fine, just revert the line and wait for it to be fixed.
There was a problem hiding this comment.
Let's not take lines in the sand. :)
We can both keep the code and report it upstream at the same time.
Packagelint is a tool but a very useful one. It's good to play nice with it even if it means tweaking the code just a little.
Think // ignore-linter type lines in other languages.
There was a problem hiding this comment.
Sure, we can keep the line and revert once it's fixed.
Found the issue: purcell/package-lint#96
@fbergroth : thanks for reporting.
No description provided.