-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exit code tests #275
base: master
Are you sure you want to change the base?
Add exit code tests #275
Conversation
Right now, this only has checks for the analyze command, but I wanted to get feedback on the usage of the helper functions in test. Sorry if it triggers a lot of CI failures! |
I like the idea! These are my thoughts on the test implementation. :D
WDYT? :) |
I think I chose the worst possible example command 💥 I want to test more than just Eask file errors and warnings, which I might have implied by this choice... A better example might be I'll add a few more examples in a new subfolder of |
No worries! I'm more keen to test this feature explicitly, so it's easier to track and test in one place. 🤔 |
6eac4fc
to
561a100
Compare
561a100
to
570077d
Compare
Before changing the behavior of errors as discussed in #273 , I wanted to add more tests that check the current behavior.
This PR adds tests which check, for each command:
--strict
is setwhen
--allow-error
is set, then exit with errorI'll add some script helpers that check error statuses and note any discrepancies I see.
I'll comment out and mark any currently failing expectations with
#FIXME
so that the CI run is clean.