Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mux modification #63

Merged
merged 17 commits into from
Nov 22, 2024
Merged

Mux modification #63

merged 17 commits into from
Nov 22, 2024

Conversation

elv-reza
Copy link
Contributor

@elv-reza elv-reza commented Oct 2, 2024 •
edited
Loading

Solves issues: #67, #68

  • Increase muxing capacity up to 4*4096 ABR segments (more than 8 hours).
  • Add capability to mux to MP4 in addition to fMP4. This can be chosen using the format in transcoding parameters.
  • During muxing adjust output PTS/DTS and start from zero.
  • Better EOF detection when muxing multiple streams.
  • Start muxing after the first keyframe detection.
  • Some enhancements and fixes in mux output seeker interface.
  • Fix a memory leak in avpipe mux when muxing is filished

elv-serban
elv-serban approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@elv-serban elv-serban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

elv-nate
elv-nate approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@elv-nate elv-nate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it would work no problem.

libavpipe/src/avpipe_mux.c Show resolved Hide resolved
elv-reza added 15 commits October 4, 2024 19:20
@elv-reza
Merge branch 'master' of github.com:eluv-io/avpipe into mux-modification
08d5bf2
@elv-reza
Merge branch 'master' of github.com:eluv-io/avpipe into mux-modification
fed7b2c
@elv-reza
Fix some corner cases
4f03cc2
@elv-reza
Add seek method for RWBuffer
3f77f32
@elv-reza
Add SeekReadWriteCloser interface to avpipe
e6cf4d0
@elv-reza
Adjust PTS and DTS of muxed output and start from 0
38c7feb
@elv-reza
Fix return value on error
d052320
@elv-reza
Better EOF detection when muxing is done
1e03e70
@elv-reza
Set audio packet duration to 1024
314b979
@elv-reza
Log modification
274d82c
@elv-reza
Fix an issue with input seek; Don't mux until a keyframe is detected
5be9e03
@elv-reza
More fix of seek operation
bb71659
@elv-reza
Fix a memory leak in avpipe mux, when muxing is complete
49258c6
@elv-reza
Update README and MPEGTS unit test fix
2adf03e
@elv-reza
Merge branch 'master' of github.com:eluv-io/avpipe into mux-modification
4f27e19
@elv-reza elv-reza merged commit 2d9c98a into master Nov 22, 2024
@elv-reza elv-reza deleted the mux-modification branch November 22, 2024 17:08
elv-serban
elv-serban reviewed Nov 22, 2024
View reviewed changes
libavpipe/src/avpipe_xc.c
Comment on lines +2262 to +2264
if (!strcmp(params->ecodec2, "aac"))
output_packet->duration = 1024;
} else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change address? (It may cover a hole in audio)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elv-serban elv-serban elv-serban approved these changes

@elv-nate elv-nate elv-nate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elv-reza @elv-serban @elv-nate