-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the unexpected corrections for plugin-di caused by biome lint #3052
Conversation
- fix the sample serviceType is undefined - fix erroneous corrections in di plugin caused by biome. - add Parameter Decorators support in biome
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Mate. Later today i wil get the final biome.json and add into all the plug. |
Relates to
Incorrect biome lint in commit:
4b9510d
cc @wtfsayo
Risks
Low
Background
What does this PR do?
Because the parameter decorator configuration is not configured in the settings.
Doc: https://biomejs.dev/blog/biome-v1/#support-for-function-class-parameter-decorators
so added this field in biome.json (and formatted the file)
The decorator for the DI plugin was incorrectly changed.
At the same time, I noticed that the serviceType of sampleService needed to be revised in its writing, otherwise it would be undefined during actual runtime, so I fixed that as well.
Changes:
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Documentation changes needed?
My changes do not require a change to the project documentation.
Discord username
bt.wood