feat: improve instagram client #2975

derrix060 · 2025-01-29T11:55:02Z

Relates to

No specific issue linked - please add if applicable

Risks

Low - This PR introduces configuration flexibility for Instagram posting intervals and image generation settings with safe fallbacks.

Background

What does this PR do?

This PR makes two main improvements:

Adds Instagram-specific posting interval settings while maintaining backwards compatibility
Enhances image generation configuration flexibility by supporting character-specific image settings

What kind of change is this?

Improvements (misc. changes to existing features)

Adds more granular control over Instagram posting intervals
Allows customization of image generation parameters per character

Documentation changes needed?

No. The documentation already suggest the usage of these parameters, but they were not being used.

Testing

Where should a reviewer start?

Review the posting interval changes in InstagramPostService
Check the image generation parameter handling with character settings

Detailed testing steps

Test posting intervals:
- Set INSTAGRAM_POST_INTERVAL_MIN and INSTAGRAM_POST_INTERVAL_MAX
- Verify they take precedence over generic POST_INTERVAL_MIN/MAX
- Confirm fallback to default values (90/180) works
Test image generation:
- Configure character image settings
- Verify all parameters are properly passed to generateImage
- Test fallback to default values when settings are not specified

Key changes:

Added Instagram-specific interval settings
Added support for character-specific image generation settings:
- width/height
- count
- negative prompt
- iterations
- guidance scale
- seed
- model ID
- job ID
- style preset
- watermark settings
- safe mode
- cfg scale

The changes maintain backwards compatibility while adding more configuration options for fine-tuned control.

There is a INSTAGRAM_ setting that should be respected first, then look into the generic one, then the default value

coderabbitai · 2025-01-29T11:55:08Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions

Hi @derrix060! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!

packages/client-instagram/src/services/post.ts

graphite-app · 2025-01-29T11:55:54Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
merge-queue-hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

Updated the image generation parameters to utilize dynamic settings from the runtime configuration. This allows for more flexible image generation based on user-defined preferences, improving the overall functionality and customization of the Instagram post service.

Expanded test coverage for Instagram client configuration and post service. Added tests for: - Environment configuration validation with enhanced image settings - Handling of partial and invalid configuration parameters - Image generation settings and fallback mechanisms - Post interval selection logic - Error handling for image generation failures

fix(instagram): get post interval setting from the correct place

1c861d2

There is a INSTAGRAM_ setting that should be respected first, then look into the generic one, then the default value

github-actions bot reviewed Jan 29, 2025

View reviewed changes

graphite-app bot reviewed Jan 29, 2025

View reviewed changes

packages/client-instagram/src/services/post.ts Outdated Show resolved Hide resolved

derrix060 added 2 commits January 29, 2025 12:17

derrix060 force-pushed the mario/improve-instagram-client branch from c22ede7 to d65f9c7 Compare January 29, 2025 12:18

Merge branch 'develop' into mario/improve-instagram-client

3076c26

derrix060 changed the title ~~Mario/improve instagram client~~ feat: improve instagram client Jan 29, 2025

Merge branch 'develop' into mario/improve-instagram-client

783a536

wtfsayo enabled auto-merge (squash) January 29, 2025 13:59

wtfsayo self-requested a review January 29, 2025 13:59

wtfsayo approved these changes Jan 29, 2025

View reviewed changes

wtfsayo merged commit c1c28f1 into elizaOS:develop Jan 29, 2025
7 of 8 checks passed

odilitime mentioned this pull request Feb 1, 2025

chore: dev => main 0.1.9 #2361

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improve instagram client #2975

feat: improve instagram client #2975

derrix060 commented Jan 29, 2025

coderabbitai bot commented Jan 29, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot left a comment

graphite-app bot commented Jan 29, 2025

feat: improve instagram client #2975

feat: improve instagram client #2975

Conversation

derrix060 commented Jan 29, 2025

Relates to

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

coderabbitai bot commented Jan 29, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot left a comment

Choose a reason for hiding this comment

graphite-app bot commented Jan 29, 2025

How to use the Graphite Merge Queue

CodeRabbit Configuration File (`.coderabbit.yaml`)