-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow custom TEE log path #2616
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @batudo! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!
@ShuochengWang do you know about the last 2 changes to TEE Log plugin? |
This indeed appears to be an issue. It is likely caused by differing initial paths. In the SGX environment, the initial path is However, in the dstack environment, the initial path seems to be the root directory? This discrepancy in paths leads to a mismatch? |
Just confirmed: This path is the same as the one I initially set, so why was this correct path modified earlier in #2415 The reason for the different starting directory in SGX is that I started the application in the Additionally, recent testing revealed that the latest version of Eliza has more WASM-related dependencies, and the SGX environment is very unfriendly to the default WASM configuration. The default WASM configuration consumes an enormous amount of memory during initialization in SGX. The current |
If you initialize the agent from the repo root, which is the intention on all README notes and tutorials, then the previous path was wrong. |
Launching in TEE Cloud using dstack requires building docker image and creating a docker-compose file to launch. So the path would be |
Well, then I think the best choice here is to use an env variable instead of a constant path @batudo |
Done, you can now configure the path via ENV. |
Relates to
#2415
Risks
Low: it only affects the TEE logs.
Background
What does this PR do?
Fixes an error when TEE logs are enabled that shows the message "Cannot open database because the directory does not exist".
What kind of change is this?
Bug fix.
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Starting an agent with tee-log enabled using TDX_DSSTACK
Detailed testing steps
Configure the agent with this env variables:
Start TEE simulator as on https://elizaos.github.io/eliza/docs/advanced/eliza-in-tee/#environment-setup
And then start the agent with:
This should not display the message "Cannot open database because the directory does not exist" when in this branch, same config with the code in main will display it.
Discord username
fcatena