Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cleanup step from integration tests workflow #2551

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 20, 2025

Remove cleanup step from integration tests workflow

This PR removes the cleanup step from the integration tests workflow as requested. The cleanup step was running pnpm clean which is no longer needed in the workflow.

Changes

  • Removed the cleanup step from the integration tests workflow
  • This change simplifies the workflow and removes an unnecessary step

Testing

The changes can be verified by:

  1. Running the integration tests workflow
  2. Confirming that the tests still pass without the cleanup step

Link to Devin run: https://app.devin.ai/sessions/ff5037c60d2f46e38d68f36060e13a2d

- Add pnpm cache step using actions/cache@v4 for node_modules and pnpm store
- Remove redundant pnpm cache from setup-node step
- Add plugin dist cache to prevent unnecessary rebuilds

Similar to the caching strategy in smoke-tests.yml, this change should
significantly reduce workflow execution time by caching both dependencies
and build artifacts.

Co-Authored-By: Sayo <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@wtfsayo
Copy link
Member

wtfsayo commented Jan 20, 2025

lets test for a while

@wtfsayo wtfsayo self-requested a review January 20, 2025 11:49
@wtfsayo wtfsayo enabled auto-merge (squash) January 20, 2025 11:49
Copy link
Member

@wtfsayo wtfsayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

under testing // will revert if doesn't work

@wtfsayo wtfsayo merged commit db3c835 into develop Jan 20, 2025
6 of 7 checks passed
@wtfsayo wtfsayo deleted the devin/1737373541-cache-integrationtests branch January 20, 2025 11:49
@devin-ai-integration devin-ai-integration bot changed the title feat: improve integrationtests workflow caching chore: remove cleanup step from integration tests workflow Jan 20, 2025
mgunnin added a commit to mgunnin/eliza-agent that referenced this pull request Jan 20, 2025
* upstream/develop:
  test configuration and tests for client-lens (elizaOS#2534)
  chore(attempt): optimize pnpm cache configuration (elizaOS#2556)
  feat: add a way to create/store/restore agents in the filesystem (elizaOS#2389)
  chore: optimize pnpm cache configuration (elizaOS#2555)
  chore: remove cleanup step from integration tests workflow (elizaOS#2553)
  feat: Add more actions to Abstract Plugin (elizaOS#2531)
  feat: add anthropic image provider for vision (elizaOS#2524)
  feat: improve integrationtests workflow caching (elizaOS#2551)
  feat: Updated READ.me file with pre-requisites to enable telegram bot (elizaOS#2547)
  feat(plugin-devin): implement client-agnostic Devin plugin (elizaOS#2549)
  use generateObject
  handle undefined env variable
  feat:add plugin-lightning (elizaOS#2429)
0xrubusdata pushed a commit to 0xrubusdata/eliza that referenced this pull request Jan 21, 2025
- Add pnpm cache step using actions/cache@v4 for node_modules and pnpm store
- Remove redundant pnpm cache from setup-node step
- Add plugin dist cache to prevent unnecessary rebuilds

Similar to the caching strategy in smoke-tests.yml, this change should
significantly reduce workflow execution time by caching both dependencies
and build artifacts.

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Sayo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant