Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPENAI provider being overwritten by LLAMA_LOCAL on pnpm start #2465

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

tcm390
Copy link
Collaborator

@tcm390 tcm390 commented Jan 17, 2025

related: #2450

Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

📝 Walkthrough

Walkthrough

The pull request introduces modifications to token handling for specific model providers in the getTokenForProvider function, adding cases for LLAMALOCAL, OLLAMA, and GAIANET that return empty strings. Additionally, the default character's model provider has been switched from OPENAI to LLAMALOCAL, and a condition in the startAgents function has been updated to check for falsy onchainJson values.

Changes

File Changes
agent/src/index.ts - Added empty string returns for LLAMALOCAL, OLLAMA, and GAIANET providers in getTokenForProvider
- Modified startAgents condition to check for falsy onchainJson
packages/core/src/defaultCharacter.ts - Changed modelProvider from ModelProviderName.OPENAI to ModelProviderName.LLAMALOCAL

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26f71dd and 68317cf.

📒 Files selected for processing (2)
  • agent/src/index.ts (2 hunks)
  • packages/core/src/defaultCharacter.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: integration-tests
  • GitHub Check: smoke-tests
  • GitHub Check: smoke-tests
  • GitHub Check: integration-tests
🔇 Additional comments (3)
packages/core/src/defaultCharacter.ts (1)

8-8: LGTM! The model provider change aligns with the PR objective.

The switch from OPENAI to LLAMALOCAL as the default model provider is consistent with the token handling changes in getTokenForProvider.

agent/src/index.ts (2)

440-446: LGTM! Token handling for local providers is properly implemented.

The empty string returns for LLAMALOCAL, OLLAMA, and GAIANET are appropriate as these providers don't require API keys.


1203-1203: Nice improvement to the falsy check!

The condition !onchainJson is more robust than checking for the string "null", as it handles all falsy values correctly.

Finishing Touches

  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tcm390 tcm390 changed the title fix model overwrite issue fix: OPENAI provider being overwritten by LLAMA_LOCAL on pnpm start Jan 17, 2025
@wtfsayo wtfsayo enabled auto-merge (squash) January 17, 2025 21:54
@wtfsayo wtfsayo self-requested a review January 17, 2025 21:58
@wtfsayo wtfsayo merged commit d2ab74e into develop Jan 17, 2025
7 of 9 checks passed
@wtfsayo wtfsayo deleted the tcm-fix-onchainJson branch January 17, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants