fix: align base url in client if api runs on a different port #2353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Risks
Low
Background
What does this PR do?
Currently, the client depends on the api (server) base url, which is hardcoded in
client/src/lib/api.ts
:If we would like to run the server on another port, we can modify the
SERVER_PORT
in.env
, while we still need to update theBASE_URL
in theclient/src/lib/api.ts
.This PR will align the server port, so that we only need to update the
.env
if we need to run the server on a different port.It also ensures the single source of credential.
What kind of change is this?
Improvements
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Run the project on a different port, and see if the client works as expected.
Detailed testing steps