feat: plugin Solana web3.js V2 & automated LPing on Orca #2136
Conversation
calintje
changed the title
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request introduces a new Solana Plugin V2 ( Changes
Possibly related PRs
Suggested Labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 16
🧹 Nitpick comments (9)
packages/plugin-solana-v2/src/providers/orca/positionProvider.ts (1)
50-50: Use consistent variable naming.Variable
FetchedPositionsStatisticsshould be in camelCase to match naming conventions.Apply this diff for consistency:
- const FetchedPositionsStatistics: FetchedPositionStatistics[] = await Promise.all(positions.map(async (position) => { + const fetchedPositionsStatistics: FetchedPositionStatistics[] = await Promise.all(positions.map(async (position) => {packages/plugin-solana-v2/src/utils/TEE/deriveKeyProvider.ts (2)
24-26: Replaceconsole.logwithelizaLoggerfor consistent logging.Use the provided logging utility for uniform log management.
Example changes:
- console.log("TEE: Connecting to local simulator at localhost:8090"); + elizaLogger.log("TEE: Connecting to local simulator at localhost:8090");Apply similar changes to other
console.logstatements.Also applies to: 30-32, 36-38, 59-62, 77-79, 92-93
107-134: Ensure consistent error handling and return values ingetmethod.Returning empty strings on error may lead to unclear failures. Consider throwing exceptions or returning
null.packages/plugin-solana-v2/src/index.ts (1)
14-21: Remove commented-outorcaPlugincode.Cleaning up unused code improves readability.
Apply this diff to remove the commented code:
-// export const orcaPlugin: Plugin = { -// name: "orca", -// description: "Orca Plugin for Eliza", -// actions: [managePositions, repositionPositions], -// evaluators: [repositionEvaluator], -// providers: [positionProvider], -// }packages/plugin-solana-v2/src/evaluators/orca/repositionEvaluator.ts (1)
38-38: Fix typo in variable name.The variable name contains a typo.
- const instervalMs = config.intervalSeconds * 1000; + const intervalMs = config.intervalSeconds * 1000;packages/plugin-solana-v2/tsup.config.ts (1)
3-26: Consider additional build optimizations.The configuration could benefit from performance improvements.
export default defineConfig({ entry: ['src/index.ts'], format: ['esm'], dts: true, splitting: false, sourcemap: true, clean: true, + minify: true, + treeshake: true, external: [package.json (1)
51-53: Well-structured version management strategy.The overrides section effectively manages multiple web3.js versions:
- v1.95.5 for NFT generation
- v1.95.8 for core and plugin-solana
- v2.0.0 for the new plugin-solana-v2
Consider documenting this version management strategy in the project's README to help future contributors understand the multi-version setup.
packages/plugin-solana-v2/README.md (2)
26-26: Fix typo: "isntance" → "instance"-- Accepts the RPC isntance, transaction instructions, and a wallet. ++ Accepts the RPC instance, transaction instructions, and a wallet.
70-76: Enhance code example with importsThe configuration example should include import statements for better clarity.
+import { managePositions, repositionPosition } from './actions'; +import { repositionEvaluator } from './evaluators'; +import { positionProvider } from './providers'; + export const solanaPluginV2: Plugin = { name: "solanaV2", description: "Solana Plugin V2 for Eliza",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (20)
agent/package.json(1 hunks)agent/src/index.ts(3 hunks)package.json(1 hunks)packages/core/package.json(1 hunks)packages/plugin-nft-generation/package.json(1 hunks)packages/plugin-solana-v2/README.md(1 hunks)packages/plugin-solana-v2/package.json(1 hunks)packages/plugin-solana-v2/src/actions/orca/managePositions.ts(1 hunks)packages/plugin-solana-v2/src/evaluators/orca/repositionEvaluator.ts(1 hunks)packages/plugin-solana-v2/src/index.ts(1 hunks)packages/plugin-solana-v2/src/providers/orca/positionProvider.ts(1 hunks)packages/plugin-solana-v2/src/utils/TEE/deriveKeyProvider.ts(1 hunks)packages/plugin-solana-v2/src/utils/TEE/remoteAttestationProvider.ts(1 hunks)packages/plugin-solana-v2/src/utils/TEE/types.ts(1 hunks)packages/plugin-solana-v2/src/utils/loadWallet.ts(1 hunks)packages/plugin-solana-v2/src/utils/sendMessage.ts(1 hunks)packages/plugin-solana-v2/src/utils/sendTransaction.ts(1 hunks)packages/plugin-solana-v2/tsconfig.json(1 hunks)packages/plugin-solana-v2/tsup.config.ts(1 hunks)packages/plugin-solana/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/plugin-solana-v2/tsconfig.json
🧰 Additional context used
🪛 LanguageTool
packages/plugin-solana-v2/README.md
[uncategorized] ~47-~47: Loose punctuation mark.
Context: ...TEE functionality. - sendTransaction: Smart transaction handling with CU opti...
(UNLIKELY_OPENING_PUNCTUATION)
🪛 Biome (1.9.4)
packages/plugin-solana-v2/src/actions/orca/managePositions.ts
[error] 219-219: Unnecessary use of boolean literals in conditional expression.
Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with
(lint/complexity/noUselessTernary)
[error] 246-246: Unnecessary use of boolean literals in conditional expression.
Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with
(lint/complexity/noUselessTernary)
🔇 Additional comments (11)
packages/plugin-solana-v2/src/utils/loadWallet.ts (1)
1-83: LGTMThe
loadWalletfunction is well-implemented, correctly handling different TEE modes and runtime settings to return the appropriate keypair or public key.agent/src/index.ts (4)
58-58: ImportingsolanaPluginV2.The import statement correctly brings in the new Solana V2 plugin.
537-537: Conditional inclusion ofsolanaPluginV2.The logic properly includes the plugin when Solana credentials are present.
609-609: AddingechoChamberPluginbased on secrets.The plugin is conditionally added when the required secrets are available.
614-614: Using.flat()to handle nested plugin arrays.Flattening the plugins array ensures correct plugin integration.
packages/plugin-solana-v2/src/utils/TEE/types.ts (2)
1-6: EnumTEEModeis well-defined.It accurately represents the different TEE modes with clear comments.
8-11: InterfaceRemoteAttestationQuoteis properly defined.The structure includes necessary properties for attestation quotes.
packages/plugin-solana/package.json (1)
27-27: LGTM! Explicit npm alias helps prevent version conflicts.The change to use
npm:@solana/[email protected]ensures consistent version resolution.packages/plugin-nft-generation/package.json (1)
30-30: LGTM! Consistent version management approach.Using
npm:@solana/[email protected]aligns with the project-wide version resolution strategy.packages/core/package.json (1)
42-42: LGTM! Maintains version consistency.The explicit npm alias for web3.js matches the project-wide approach.
agent/package.json (1)
51-51: Verify integration with existing Solana plugin.The addition of
@elizaos/plugin-solana-v2alongside the existing v1 plugin requires careful consideration of plugin initialization order and potential conflicts.✅ Verification successful
No plugin conflict risk detected
The codebase implements controlled loading of Solana plugins:
- V2 plugin loads for standard Solana operations
- V1 plugin only activates in TEE mode with specific configuration
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for potential plugin conflicts rg -A 5 "plugin-solana|plugin-solana-v2" | grep -i "initialize\|setup\|configure"Length of output: 368
Script:
#!/bin/bash # Search for plugin imports and usage echo "=== Checking imports and plugin registration ===" rg -l "plugin-solana-v2|@elizaos/plugin-solana-v2" echo -e "\n=== Checking plugin initialization patterns ===" ast-grep --pattern 'import $_ from "@elizaos/plugin-solana$$$"' ast-grep --pattern 'import $_ from "@elizaos/plugin-solana-v2$$$"' echo -e "\n=== Looking for plugin registration code ===" rg -A 5 "registerPlugin|addPlugin|usePlugin"Length of output: 5800
Script:
#!/bin/bash echo "=== Checking agent initialization code ===" cat agent/src/index.ts echo -e "\n=== Looking for plugin configuration patterns ===" ast-grep --pattern 'new AgentRuntime($$$)'Length of output: 37411
|
I'm ready to do the merge. Let me know when you will prioritize this PR, so I can resolve the merge conflicts. |
Head branch was pushed to by a user without write access
Background
What does this PR do?
plugin-solana-v2, leveraging the latest features of@solana/web3.jsv2@solana/web3.jsv1.@solana/web3.jsv2pluting-teeusesKeypairfrom@solana/web3.jsv1, while v2 usesCryptoKeyPairfrom the web api. To account for this, I added some utils that add TEE functionality for solana-plugin-v2 as well (tested locally).repositionThresholdBps).What kind of change is this?
Features (non-breaking change which adds functionality)
Why are we doing this? Any context or related work?
Future proof Eliza for new projects that build on top of the new Solana SDK.
Documentation changes needed?
My changes do not require a change to the project documentation.
I added a README to the plugin.
Testing
I'm currently still testing the stability of the repositioning functionality. The behavior of the agent is at times unpredictable. I would like one of the core devs to give me guidance on the following:
Where should a reviewer start?
TBA
Detailed testing steps
TBA
Discord username
@calintje
Summary by CodeRabbit
Release Notes for Solana Plugin V2
New Features
Improvements
@solana/web3.jsv2 with modern JavaScript practicesDependencies
@elizaos/plugin-solana-v2package