Update README_CN - Model Configuration #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original model configuration guide is misleading, it tells readers to configure model provider by change the `XAI_MODEL` parameters. But this is for the XAI configurations, i update the description completely with the right configuration steps.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @RedHorse823! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!
monilpat
approved these changes
Dec 28, 2024
1to3for5vi7ate9x
pushed a commit
to 1to3for5vi7ate9x/eliza
that referenced
this pull request
Jan 26, 2025
Update README_CN - Model Configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
README_CN
Risks
Low - Changes the README file
Background
What does this PR do?
Update the README_CN file for right and clear instructions
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Why are we doing this? Any context or related work?
The original model configuration guide is misleading, it tells readers to configure model provider by change the
XAI_MODELparameters.But this is for the XAI configurations, i update the description completely with the right configuration steps.
Documentation changes needed?
I have updated the documentation accordingly.
Testing
Where should a reviewer start?
Simply check the only modified file
Detailed testing steps
Might need translation if the reviewer doesn't speak Chinese
Discord username
dftba777777#4421