Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade your hackney dependency when possible #751

Closed
Trevoke opened this issue Feb 18, 2025 · 3 comments · Fixed by #752
Closed

Please upgrade your hackney dependency when possible #751

Trevoke opened this issue Feb 18, 2025 · 3 comments · Fixed by #752

Comments

@Trevoke
Copy link

Trevoke commented Feb 18, 2025

Hello,

Recently, a CVE (Common Vulnerability and Exposure) was created for one of your dependencies, hackney.

Hackney is aware of this ( benoitc/hackney#751 ) and will create a release soon ( benoitc/hackney#753 (comment) ).

When the new hackney release comes out, please create a new tesla release incorporating this security update.

Thank you!

@yordis
Copy link
Member

yordis commented Feb 18, 2025

Thank you for the head up,

:hackney is an optional step so that you can manage the version in your app; there is no need to release a new version unless I am missing something.

I am watching the issue; I will upgrade the dependency in the package.

@grzuy
Copy link

grzuy commented Feb 19, 2025

tesla declares itself compatible with hackney ~> 1.6 (https://github.com/elixir-tesla/tesla/blob/master/mix.exs#L59).

So apps depending on latest tesla won't have any problem upgrading to an hypothetical upcoming hackney 1.20.2 or even hackney 1.21 with mix deps.update hackney.

@grzuy
Copy link

grzuy commented Feb 19, 2025

For what is worth, the pinned version of hackney in tesla's mix.lock doesn't affect packages or apps depending on tesla, it only affects which version of hackney tesla is using to run tests or developing tesla locally.

yordis added a commit that referenced this issue Feb 20, 2025
yordis added a commit that referenced this issue Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants