Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server says it supports workspace folders but it does not support didChangeWorkspaceFolders #296

Closed
axelson opened this issue Jun 14, 2020 · 0 comments · Fixed by #298
Closed

Server says it supports workspace folders but it does not support didChangeWorkspaceFolders #296

axelson opened this issue Jun 14, 2020 · 0 comments · Fixed by #298

Comments

@axelson
Copy link
Member

axelson commented Jun 14, 2020

From #295 there is the log:

[Warn - 12:44:50 PM] warning: Received unmatched notification: %{"jsonrpc" => "2.0", "method" => "workspace/didChangeWorkspaceFolders", "params" => %{"event" => %{"added" => [%{"name" => "web", "uri" => "file:///Users/sashaafm/Documents/project/frontend/web"}], "removed" => []}}}

From https://microsoft.github.io/language-server-protocol/specification#workspace_didChangeWorkspaceFolders we see:

The notification is sent by default if both client capability workspace.workspaceFolders and the server capability workspace.workspaceFolders.supported are true;

So worksSpace folders should be set to false for ElixirLS (until support is added)
This was referenced Jun 14, 2020
Closed
Merged
axelson added a commit that referenced this issue Jun 19, 2020
@axelson
Do not advertise workspaceFolder support (#298)
5102f1c 
* Do not advertise workspaceFolder support

In #295 the user received a
warning:

> Received unmatched notification: %{"jsonrpc" => "2.0", "method" =>
  "workspace/didChangeWorkspaceFolders"

This occurs because the server advertises that it supports workspace folders:
https://microsoft.github.io/language-server-protocol/specification#workspace_workspaceFolders

This was introduced in #35 which was
actually about didChangeWatchedFiles and not workspace folders.

Fixes #296

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not advertise workspaceFolder support
1 participant
@axelson