Save sidebar state per session

[cw789]

Means sidebar stays open or close if you navigate.
For example using previous / next page navigation.

Close #1554

Additionally I needed to fix a CSS animation.
By doing so I moved the sidebar button 7px more from left & top into the page.
Found it unwanted to have a different height position between closed / opened sidebar.

[josevalim]

Can you please revert the button changes? I am pretty sure it was intentional in the design. :)

[cw789]

If I keep the transition on body.sidebar-closed .sidebar-button the button will always initially fly from left to right if sidebar will be closed. If I just set the transition to nonethe button will jump 8px to the top on closing the sidebar.

But yes I see the intention now. It's so to have the button centered within the kept free space (for the button) on narrow screens. The 8px move up is just to have it visually aligned to the corner when closed or to the search input then opened.

[cw789]

I've tested some things but do not find a real solution.
But I found out the left to right flying sidebar-button on initial page load is nothing new.
It already occurred on narrow screens with the current implementation.

So from my side it's ok to leave this behavior as is.

[josevalim]

💚 💙 💜 💛 ❤️

[josevalim]

Unfortunately this introduces a bug:

1. If I close the sidebar
2. Then I open it
3. And then make the screen small, the sidebar no longer collapses automatically

I think we should only store the closed state. Can you please send a pull request? I will revert this PR meanwhile.

[cw789]

I thought this behavior is what to expect.
No magic happening on rotation or size changes.

But ok on my side if this little magic is expected. I'll have a look.

[josevalim]

Thank you!