Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize html/epub tests by making them asyncronous by using tmp_dir tag #1557

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

eksperimental
Copy link
Contributor

No description provided.

@wojtekmach
Copy link
Member

Can we use ExUnit @tag :tmp_dir instead? We should be on a recent enough Elixir version to be able to use it.

@eksperimental
Copy link
Contributor Author

Can we use ExUnit @tag :tmp_dir instead? We should be on a recent enough Elixir version to be able to use it.

I like this. We may even be able to run concurrent tests. I will work on it.

@eksperimental eksperimental changed the title Convert to macro test helpers to get called multiple times Optimize html/epub tests by making them asyncronous by using tmp_dir tag Apr 21, 2022
@eksperimental
Copy link
Contributor Author

This is ready for reviewing @wojtekmach

@josevalim josevalim merged commit cf8530a into elixir-lang:main Apr 24, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@eksperimental eksperimental deleted the optimize_helpers branch April 24, 2022 12:33
eksperimental added a commit to eksperimental-forks/ex_doc that referenced this pull request Apr 24, 2022
josevalim pushed a commit that referenced this pull request Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants