-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support {:all, endpoint} in :services
to auto-discover
#49
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,15 +11,15 @@ defmodule GrpcReflection do | |
defmodule Helloworld.Reflection.Server do | ||
use GrpcReflection.Server, | ||
version: :v1, | ||
services: [Helloworld.Greeter.Service] | ||
services: [Helloworld.Greeter.Service] # alternatively, `{:all, HelloWorld.Endpoint}` can be used to include all services from the endpoint. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't describe Maybe something like:
|
||
end | ||
``` | ||
|
||
2. Add the reflection supervisor to your supervision tree | ||
```elixir | ||
children = [ | ||
GrpcReflection, | ||
{GRPC.Server.Supervisor, endpoint: Helloworld.Endpoint, port: 50051, start_server: true}, | ||
GrpcReflection | ||
Comment on lines
+21
to
-22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not related to the PR, but I believe this is the correct order, as the server has dependency on infra started by the |
||
] | ||
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this list is starting to get a bit dense with the config options inlined in these paragraphs. Now that
services
has multiple forms what do you think about simplifying this instruction list and moving the config descriptions into a separate block? I think the two forms for the content of theservices
entry should be together.