-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add precompiled NIFs for freebsd #618
Conversation
The default is cross v0.2.4 which was created in Juli of 2022 [0]. The patch to add libmemstat [1] was created in December of 2022, so we need a newer version of cross. [0] https://github.com/cross-rs/cross/pkgs/container/x86_64-unknown-freebsd/28076628?tag=0.2.4 [1] cross-rs/cross#1166
I would keep the @maltekrupa another important thing is that we may need to change |
Thank you for the quick response.
Ok, what about the other targets that use cross? Should they stay on the old cross+ubuntu version too?
Cool, I'll check that next. |
@maltekrupa I think we can keep the newer version of cross, unless it's not compatible with most of the targets. |
This introduces a new variable `cross-version` which defaults to v0.2.4 and is set to v0.2.5 for freebsd. It is required because cross v0.2.5 fails to build on ubuntu-20.04.
@maltekrupa thanks for the updates! I think we need one more thing: add the target to the list of targets here: And also, I decided to not force this new target as default for now (in |
Thank you for taking the time to guide me through everything!
Done 👍
Sounds good to me. :) |
Hi, I'm trying to use Explorer 0.8.2 on FreeBSD 14 (in a LiveBook) and I'm getting this error:
Is the |
Hi,
as discussed in #617, this will add precompiled NIFs for freebsd.
The solution was to use a more recent version of https://github.com/cross-rs/cross. Since this failed on
ubuntu-20.04
, the OS had to be set to a newer version too (ubuntu-22.04
).I left the other targets untouched but it'd probably make sense to update the OS for them too. Either here or in a new PR. What do you think?
Best
Malte