Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry badges update #639

Merged
merged 9 commits into from
Jul 6, 2021
Merged

Registry badges update #639

merged 9 commits into from
Jul 6, 2021

Conversation

bedroesb
Copy link
Member

@bedroesb bedroesb commented Jul 2, 2021

This part is a start to make the linking of tools to other registries more clear. The current look in the screenshot is not final and I need help in deciding what will be the text in the badge, and what will be the text when you hover over it.

Preview website

Screenshot from 2021-07-02 15-56-32

@lauportell @korbinib @martin-nc

TO DO:

  • 1. bio.tools has a lowercase 'b' at the beginning. Of course that's not usual in a proper noun, but there we are.
  • 2. I would make all the labels consistent, so they just name the resource: 'FAIRsharing', 'bio.tools' and 'TeSS'. Then when you hover over them you'd get: 'Find related policies and standards' (FAIRsharing), ' Find a scientific and technical description of the resource' (bio.tools) and 'Find training for this resource' (TeSS).
  • 3. I'm not sure about the label colours. I wouldn't know which orange applied to which resource, and orange is a warm colour so it jumps out. I'd be worried it jumped out more than the actual resource/tool name! Maybe they should all be the same colour, but a cooler one. Would the link blue work as a background? Or the dark grey or dark blue we have in the style guide (with contrast reversed)?
  • 4. I'd make the table heading sticky.
  • 5. I find the hover state on the rows distracting. I think the table rows are big enough for you to understand which one you are on. Maybe that's just my taste, though.

@bedroesb bedroesb requested a review from martin-nc as a code owner July 2, 2021 14:10
@martin-nc
Copy link

martin-nc commented Jul 2, 2021

Here are a few thoughts:

  1. bio.tools has a lowercase 'b' at the beginning. Of course that's not usual in a proper noun, but there we are.
  2. I would make all the labels consistent, so they just name the resource: 'FAIRsharing', 'bio.tools' and 'TeSS'. Then when you hover over them you'd get: 'Find related policies and standards' (FAIRsharing), ' Find a scientific and technical description of the resource' (bio.tools) and 'Find training for this resource' (TeSS).
  3. I'm not sure about the label colours. I wouldn't know which orange applied to which resource, and orange is a warm colour so it jumps out. I'd be worried it jumped out more than the actual resource/tool name! Maybe they should all be the same colour, but a cooler one. Would the link blue work as a background? Or the dark grey or dark blue we have in the style guide (with contrast reversed)?
  4. I'd make the table heading sticky.
  5. I find the hover state on the rows distracting. I think the table rows are big enough for you to understand which one you are on. Maybe that's just my taste, though.

EDIT: another thought related to 2. Maybe there should be a key at the bottom of the table explaining what the 'Registry' column means. We could even have an asterisk next to the column heading, then at the bottom of the table put:

* Links to related information in ELIXIR registries: related policies and standards in FAIRsharing, scientific and technical descriptions of the resource in bio.tools, and related training in TeSS.

This would be good for mobile users and other who don't or can't hover. The names of the registries would be links, of course.

@bedroesb
Copy link
Member Author

bedroesb commented Jul 5, 2021

@martin-nc Thanks martin for the feedback, one thing I was wondering, we now have the info icon next the the Tool or resource column, can't we use the same to explain the registry column?

@martin-nc
Copy link

@bedroesb Yes, that's an idea. Do you mean instead of hovering over the registry name, or instead of a footnote, or instead of both?

The Tool or resource icon isn't in your screenshot, though, for some reason.

@bedroesb
Copy link
Member Author

bedroesb commented Jul 5, 2021

@martin-nc true because the table gets explained in the text above the all tools and resources page. The info icon only gets used in the tool tables on the other pages.

@bedroesb
Copy link
Member Author

bedroesb commented Jul 5, 2021

@martin-nc the sticky header doesn't seem to work in combination with overflow-x: auto; and the solutions are not straight forward

@lauportell
Copy link
Contributor

Hi Bert, sorry I didn't say anything about this before. I agree with all Martin's suggetions and I think it looks very good right now. I don't think they need different colours and it is perfect that when you hover over you see the explaination of what you will find when you click. Thank you!!

@martin-nc
Copy link

@bedroesb Ah, okay - I don't think it's worth going to that length. Maybe leave them non-sticky for now.

@martin-nc
Copy link

martin-nc commented Jul 5, 2021

Actually, I've just had another thought (sorry!). Would it look better to make the first column bold and decrease the font size of the description to .9em or so, just to decrease the length of the table and make the tool name stand out more? I guess something like (untested!):

td:nth-child(1) a {font-weight: bold;}
td:nth-child(2) {font-size: .9em;}

Anyway, it's just a thought.

@bedroesb
Copy link
Member Author

bedroesb commented Jul 6, 2021

I think it is an improvement, you can see the update in the preview. Thanks @martin-nc !

@bedroesb bedroesb merged commit 3bc7482 into master Jul 6, 2021
@bedroesb bedroesb deleted the new-registry-style branch July 6, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants