Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update landingpage.html #481

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Update landingpage.html #481

merged 1 commit into from
Mar 30, 2021

Conversation

DanFaria
Copy link
Contributor

No description provided.

@DanFaria DanFaria requested a review from bedroesb as a code owner March 30, 2021 08:53
@bedroesb bedroesb requested a review from martin-nc March 30, 2021 09:01
martin-nc
martin-nc approved these changes Mar 30, 2021
View reviewed changes
Copy link

@martin-nc martin-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wondered if the last sentence was necessary? Not a big deal, just a comment.

@DanFaria
Copy link
Contributor Author

I felt it was relevant to provide a brief explanation of the navigation paradigm, and Bert agreed with it, but if nobody else feels it is needed, we can just scratch this pull request.

@bedroesb
Copy link
Member

bedroesb commented Mar 30, 2021 •
edited
Loading

I think it serves nice as atransition towards the structure of the side. But that is just my opinion :)

@martin-nc
Copy link

Let's leave it in then.

@bedroesb bedroesb merged commit a1526ae into master Mar 30, 2021
@bedroesb bedroesb deleted the DanFaria-patch-1 branch March 30, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-nc martin-nc martin-nc approved these changes

@bedroesb bedroesb bedroesb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanFaria @bedroesb @martin-nc