Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme improvements #456

Merged
merged 6 commits into from
Mar 23, 2021
Merged

Theme improvements #456

merged 6 commits into from
Mar 23, 2021

Conversation

bedroesb
Copy link
Member

@bedroesb bedroesb commented Mar 23, 2021

With this pull request it will be possible to serve pages on different URLs than root allowing:

https://rdmkit.elixir-europe.org/your_domain/marine_metagenomics.html

+ more css variables for easy reuse of the theme ( will be improved if scss is used)

@bedroesb bedroesb requested a review from martin-nc March 23, 2021 10:28
@martin-nc
Copy link

Looks okay to me! Makes sense using the relative urls.

On the CSS variables: are they overriding Bootstrap ones or are they new ones? Might be simpler to override Bootstrap ones, that's all, especially if we move to SASS.

@bedroesb
Copy link
Member Author

Do you mean the color variables like --bs-blue and so on?

@martin-nc
Copy link

Sorry - yes I did.

@bedroesb
Copy link
Member Author

problem is that if I now overwrite for example --bs-pink and I use this theme for another project, I will have to overwrite/use another bs-color variable. Or maybe I see things wrongly :)

@martin-nc
Copy link

I was just thinking in terms of SASS. I think Bootstrap declares it's colours in a SASS map (like an associative array). Then the variables in this map will be passed through certain functions to generate colour schemes for different elements. If you override these variables then you can still take advantage of the built-in Bootstrap functions for them. If you create your own colours then I'm not sure if you can take advantage of these functions so easily.

If you wanted to change the theme slightly for another site you could choose choose different values for the variable in each site, I guess? I'm assuming we're just talking about colour changes. I think you would have a main SASS file where you would import Bootstrap functions and mixins, then have a code block where you override Bootstrap SASS variables, then you import the other Bootstrap SASS files. So you just have to change that code block (a SASS map) for each site. Anyway, let's go with what there is for now!.

@bedroesb
Copy link
Member Author

@martin-nc you seem to describe what I want, lets have a look into this we we move to scss!

@bedroesb bedroesb merged commit 70c4a46 into master Mar 23, 2021
@bedroesb bedroesb deleted the theme branch March 29, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants