Highlight atom map keys that end with a newline #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@J3RN can you pull in latest master? The CI has switched to Github Actions and should go green now |
J3RN
force-pushed
the
map-newline-highlight
branch
from
e6a18e0 to
58a0182
Compare
|
Would you be able to add a test for this so we ensure there is no regression with future updates? |
jsmestad
approved these changes
Mar 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Presently, the atom face is not applied to the syntactic-sugar (flipped colon) atom keys in a map if the value for key is on the next line.
Solution
Small change for the
rxto accept either a space or a newline after the key. For whatever reason (probably a good one), newlines are not considered part of the "space" class.