Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with the upstream v6.8.0 #77

Merged
merged 248 commits into from
Jan 22, 2024
Merged

Sync with the upstream v6.8.0 #77

merged 248 commits into from
Jan 22, 2024

Conversation

hankwallace
Copy link

@hankwallace hankwallace commented Jan 20, 2024

Overview

  • This updates our fork with v6.8.0 in the upstream repo. The plan is to upgrade further after this is merged.
  • After resolving conflicts, I compared all changes with the changes in the upstream from v6.6.0 to v6.8.0. Link is here
  • Also added our company logo to the web ui banner.

How it was tested

  • Built and ran unit tests
  • Configured docker-compose to use MySQL, started it, and ran all of our integration tests against it.
  • Configured docker-compose to use PostgreSQL, started it, and ran all of our integration tests against it.

Checklist

  • The title contains a short meaningful summary
  • I have added a link to this PR in the Jira issue
  • I have described how this was tested
  • I have included screen shots for changes that affect the user interface
  • I have updated unit tests
  • I have run unit tests locally
  • I have updated documentation (including README)

tadgh and others added 30 commits August 27, 2021 13:34
Subscription tests fail ...
the Ubuntu runner base image already includes Helm 3.7.0
* master:
  Update application.yaml
  Bumped version of Spring Boot in order to fix same issue as jmix-projects/jmix-security#90
  Upgraded to 5.6.0 Subscription tests fail ...
  Added OpenAPI / Swagger option
  simplified helm chart
  build ARM-compatible images
  bumped dependencies to latest
  only push build images to DockerHub
  Adds ability to change HAPI FHIR JPA server's port with the environment variable server.port
  Adds ability to control the number of executor threads through environment variables server.tomcat.max-threads and server.tomcat.min-spare-threads.  There is not a breaking change and does not affect the function of the JPA server unless these environment variables are set.
  Adds ability to use delete-expunge operations to the JPA Starter Server.

# Conflicts:
#	pom.xml
#	src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java
#	src/main/java/ca/uhn/fhir/jpa/starter/Application.java
#	src/main/java/ca/uhn/fhir/jpa/starter/EnvironmentHelper.java
#	src/main/java/ca/uhn/fhir/jpa/starter/FhirServerConfigCommon.java
#	src/main/java/ca/uhn/fhir/jpa/starter/FhirServerConfigDstu2.java
#	src/main/java/ca/uhn/fhir/jpa/starter/FhirServerConfigDstu3.java
#	src/main/java/ca/uhn/fhir/jpa/starter/FhirServerConfigR4.java
#	src/main/java/ca/uhn/fhir/jpa/starter/FhirServerConfigR5.java
registering ValueSetOperationProvider
updated helm chart to use image v5.6.0
@semicolin
Copy link

@hankwallace why did those checks fail for "Lint and Test Charts"?

@semicolin
Copy link

If this is updating our fork from 6.6.0 -> 6.8.0, why does it include upstream commits from 3 years ago (5.6.0)?

@hankwallace
Copy link
Author

@hankwallace why did those checks fail for "Lint and Test Charts"?

I hadn't noticed those until you pointed them out. Those are all related to kubernetes deployment test. They appear to be related to blob verification. There is even a pull request submitted against the component repo to add an option to disable this functionality.

helm/chart-testing-action#131

Since we don't deploy with kubernetes, I'd like to move forward without having to resolve these.

@hankwallace
Copy link
Author

If this is updating our fork from 6.6.0 -> 6.8.0, why does it include upstream commits from 3 years ago (5.6.0)?

Thats a good question. I assume that the method I used to merge commits was different that the one that @shubhamparikh927 had used in the past.

@hankwallace hankwallace merged commit b699884 into master Jan 22, 2024
6 of 9 checks passed
@hankwallace hankwallace deleted the sync-6.8.0 branch January 25, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.