Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add thai language #1988

Merged
merged 3 commits into from
Feb 10, 2025
Merged

feat: add thai language #1988

merged 3 commits into from
Feb 10, 2025

Conversation

jo-elimu
Copy link
Member

Issue Number

Purpose

Technical Details

Testing Instructions

Screenshots


Format Checks

Note

Files in PRs are automatically checked for format violations with mvn spotless:check.

If this PR contains files with format violations, run mvn spotless:apply to fix them.

@jo-elimu jo-elimu self-assigned this Feb 10, 2025
@jo-elimu jo-elimu requested a review from a team as a code owner February 10, 2025 09:38
@jo-elimu jo-elimu linked an issue Feb 10, 2025 that may be closed by this pull request
coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.10%. Comparing base (fcda126) to head (d1620ab).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1988   +/-   ##
=========================================
  Coverage     16.10%   16.10%           
  Complexity      483      483           
=========================================
  Files           257      257           
  Lines          7801     7801           
  Branches        800      800           
=========================================
  Hits           1256     1256           
  Misses         6495     6495           
  Partials         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 10, 2025
Copy link
Contributor

coderabbitai bot commented Feb 10, 2025

Walkthrough

This update integrates Thai language support into the project. A new deployment entry for the Thai database is added to the README, and a corresponding language mapping (language.tha=Thai) is included in the internationalization properties file. Additionally, the FAQ in the publish JSP now lists Thai alongside Hindi and Tagalog, with its hyperlink updated from Jira to GitHub, and a new CSS rule is introduced for styling the Thai language banner. No changes were made to the overall application structure or control flow.

Changes

Files Change Summary
README.md, src/.../i18n/messages_en.properties Added Thai language support: a new production deployment URL in the README and a new language mapping (language.tha=Thai) in the properties file.
src/.../jsp/contributions/publish.jsp, src/.../css/styles.css Updated the FAQ in publish.jsp to include Thai (updating the language support text and hyperlink from Jira to GitHub) and added a CSS rule for Thai styling.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fcda126 and d1620ab.

⛔ Files ignored due to path filters (3)
  • pom.xml is excluded by !**/*.xml
  • src/main/config/centos-stream-9/opt/jetty-base/webapps/webapp-THA.xml is excluded by !**/*.xml
  • src/main/webapp/static/img/banner-th.jpg is excluded by !**/*.jpg, !**/*.jpg
📒 Files selected for processing (4)
  • README.md (1 hunks)
  • src/main/webapp/WEB-INF/i18n/messages_en.properties (1 hunks)
  • src/main/webapp/WEB-INF/jsp/contributions/publish.jsp (1 hunks)
  • src/main/webapp/static/css/styles.css (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md

14-14: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


14-14: Bare URL used
null

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build (windows-latest, 21)
  • GitHub Check: build (windows-latest, 17)
  • GitHub Check: build (ubuntu-latest, 21)
  • GitHub Check: test_rest_ENG
  • GitHub Check: build (ubuntu-latest, 17)
  • GitHub Check: test_ui_ENG
🔇 Additional comments (4)
src/main/webapp/WEB-INF/jsp/contributions/publish.jsp (1)

69-71: LGTM!

The changes correctly update the FAQ to include Thai language support and improve documentation accessibility by updating the link to GitHub.

README.md (1)

14-14: LGTM!

The Thai deployment URL is correctly added, maintaining consistency with other language entries.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

14-14: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


14-14: Bare URL used
null

(MD034, no-bare-urls)

src/main/webapp/static/css/styles.css (1)

31-33: Verify the Thai banner image exists.

The CSS rule follows the established pattern for language-specific banners.

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Verify that the Thai banner image exists
fd -t f "banner-th.jpg" "src/main/webapp/static/img"

Length of output: 91


Thai Banner Image Verified
The Thai banner image (src/main/webapp/static/img/banner-th.jpg) exists as expected, so the CSS rule is correctly referencing an existing file.

src/main/webapp/WEB-INF/i18n/messages_en.properties (1)

104-104: LGTM!

The Thai language entry follows the established pattern and uses the correct ISO language code.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jo-elimu jo-elimu changed the title feat: add thai - upgrade model lib feat: add thai Feb 10, 2025
@jo-elimu jo-elimu changed the title feat: add thai feat: add thai language Feb 10, 2025
@jo-elimu jo-elimu merged commit 0ac687d into main Feb 10, 2025
10 of 12 checks passed
@jo-elimu jo-elimu deleted the 1987-add-support-for-thai-language branch February 10, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Thai language
2 participants