Enable the additional parsers to support multiple import formats. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying `koanf` library supports json, toml and yaml in addition to dotenv. The goss import command now supports these other formats through the use of the `--format flag`. ```bash goss import -f test.toml -t SecureString -p /dev --format toml ```
GitOpsBot
reviewed
Sep 29, 2020
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (97.4%)
Files: 9
Issues: 3
gofmt: 100%
go_vet: 100%
golint: 77%
cmd/completion.go
Line 1: warning: package comment should be of the form "Package cmd ..." (golint)
cmd/env.go
Line 1: warning: package comment should be of the form "Package cmd ..." (golint)
gocyclo: 100%
ineffassign: 100%
license: 100%
misspell: 88%
cmd/root.go
Line 20: warning: "Paramter" is a misspelling of "Parameter" (misspell)
This report was generated using GoGitOps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying
koanflibrary supports json, toml and yaml in additionto dotenv. The goss import command now supports these other formats
through the use of the
--format flag.