Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Refactor / Devops #57

Merged
merged 42 commits into from
Nov 17, 2022
Merged

Build Refactor / Devops #57

merged 42 commits into from
Nov 17, 2022

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Nov 13, 2022

Ready for review Powered by Pull Request Badge

This changeset refactors the Elide library build to use convention plugins, written in Kotlin, and completes a number of other cleanups and refactors. See below for details.

Changelog

  • Plugin bump -> 1.0.0-beta11
  • Version bump -> 1.0-v3-alpha1-rc33
  • Begin to adopt shared Micronaut version catalog
  • Write convention plugins for common module profiles
  • Adopt convention plugins, cleanup module build scripts
  • Centralize as much common plugin config as possible
  • Opt-in to context receivers support
  • Dependency upgrades (see relevant section)
  • Rebuild docs and reports
  • Add module for bom / version catalog sharing for Elide
  • Native test support, build refactors for GraalVM testing
  • Ship reachability metadata with Elide Server lib
  • Investigate shipping without kotlin-stdlib
  • Drop support for legacy compilers (JS, JVM)
  • Add new ssg module for generating static content (not yet implemented)

Dependency upgrades

  • GraalVM SDK: 22.3.0
  • Protobuf: 3.21.2
  • gRPC: 1.50.2
  • GAX: 2.19.5
  • Netty: 4.1.85.Final
  • TCNative: 2.0.54.Final
  • Micronaut Plugin: 3.6.4
  • AtomicFU: 0.18.5
  • Kotlin UUID: 0.6.0

@sgammon sgammon added this to the Release R1: Alpha 1 milestone Nov 13, 2022
@sgammon sgammon self-assigned this Nov 13, 2022
@sgammon sgammon force-pushed the v3-build-refactor branch 6 times, most recently from ac8a554 to 012db0d Compare November 13, 2022 23:47
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #57 (0723afe) into v3 (eb98b0f) will increase coverage by 3.83%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                 v3      #57      +/-   ##
============================================
+ Coverage     63.82%   67.65%   +3.83%     
- Complexity      352      369      +17     
============================================
  Files            70       72       +2     
  Lines          2554     2557       +3     
  Branches        226      225       -1     
============================================
+ Hits           1630     1730     +100     
+ Misses          862      755     -107     
- Partials         62       72      +10     
Impacted Files Coverage Δ
...alvm/src/main/kotlin/elide/server/SSRExtensions.kt 0.00% <ø> (ø)
...g/src/main/kotlin/elide/tool/ssg/RequestFactory.kt 0.00% <0.00%> (ø)
...ssg/src/main/kotlin/elide/tool/ssg/SiteCompiler.kt 0.00% <0.00%> (ø)
...src/jvmMain/kotlin/elide/server/ElideServerTest.kt 0.00% <0.00%> (ø)
...ages/test/src/jvmMain/kotlin/elide/testing/Test.kt 0.00% <0.00%> (ø)
...src/main/kotlin/elide/server/assets/AssetReader.kt
...src/main/kotlin/elide/runtime/graalvm/JsRuntime.kt 29.57% <0.00%> (+29.57%) ⬆️
...in/kotlin/elide/runtime/graalvm/JsRuntimeConfig.kt 71.42% <0.00%> (+71.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb98b0f...0723afe. Read the comment docs.

@sgammon sgammon force-pushed the v3-build-refactor branch 2 times, most recently from 509a3d7 to 892b7d4 Compare November 13, 2022 23:59
@sgammon sgammon added ci:build-img-jvm Trigger JVM Docker image builds ci:build-img-native Trigger native Docker image builds ci:build-native Build native targets in CI ci:buf-breaking-ignore Ignore breaking proto changes ci:test-native Run native tests ✋ embargoed PRs and issues that can't proceed because of some non-code condition feature Large PRs or issues with full-blown features platform:jvm PRs and issues relating to JVM support. release Release-related PRs and tracking issues tools Issues and PRs related to tooling labels Nov 14, 2022
@sgammon sgammon force-pushed the v3-build-refactor branch 4 times, most recently from a288455 to 6addde4 Compare November 14, 2022 08:52
@sgammon sgammon removed ci:build-img-jvm Trigger JVM Docker image builds ci:build-img-native Trigger native Docker image builds labels Nov 14, 2022
@sgammon sgammon force-pushed the v3-build-refactor branch 3 times, most recently from bc36f72 to e32ce1e Compare November 14, 2022 20:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sgammon sgammon marked this pull request as ready for review November 17, 2022 22:56
@sgammon sgammon merged commit bfc32df into v3 Nov 17, 2022
@sgammon sgammon deleted the v3-build-refactor branch November 17, 2022 23:00
@sgammon sgammon removed the ✋ embargoed PRs and issues that can't proceed because of some non-code condition label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:buf-breaking-ignore Ignore breaking proto changes ci:build-img-jvm Trigger JVM Docker image builds ci:build-img-native Trigger native Docker image builds ci:build-native Build native targets in CI ci:deploy-samples Deploy sample apps ci:test-native Run native tests feature Large PRs or issues with full-blown features platform:jvm PRs and issues relating to JVM support. release Release-related PRs and tracking issues tools Issues and PRs related to tooling
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant