Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): closer compliance for url js intrinsic #314

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Jul 24, 2023

Ready for review

  • fix: make port return null if no port is declared
  • test: add initial wpt tests for url intrinsic

@sgammon sgammon added bug Something isn't working javascript Features and issues relating to JS labels Jul 24, 2023
@sgammon sgammon self-assigned this Jul 24, 2023
@github-actions github-actions bot added the platform:jvm PRs and issues relating to JVM support. label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #314 (653339b) into v3 (ff4ba6c) will decrease coverage by 0.04%.
The diff coverage is 78.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #314      +/-   ##
==========================================
- Coverage   53.81%   53.78%   -0.04%     
==========================================
  Files         260      260              
  Lines        8824     8821       -3     
  Branches     1260     1259       -1     
==========================================
- Hits         4749     4744       -5     
- Misses       3679     3687       +8     
+ Partials      396      390       -6     
Flag Coverage Δ
jvm 53.78% <78.12%> (-0.04%) ⬇️
lib 55.22% <78.12%> (-0.04%) ⬇️
substrate 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...me/gvm/internals/intrinsics/js/url/URLIntrinsic.kt 91.19% <78.12%> (+0.44%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4ba6c...653339b. Read the comment docs.

@sgammon sgammon force-pushed the feat/url-intrinsic-null-port branch from 1de370f to 7b63bc2 Compare July 26, 2023 00:54
@sgammon sgammon marked this pull request as ready for review July 26, 2023 00:54
sgammon added 2 commits July 25, 2023 17:56
- fix: make `port` return `null` if no port is declared
- test: add initial wpt tests for url intrinsic
@sgammon sgammon force-pushed the feat/url-intrinsic-null-port branch from 7b63bc2 to 653339b Compare July 26, 2023 00:56
@sgammon sgammon enabled auto-merge July 26, 2023 08:12
@sgammon sgammon disabled auto-merge July 26, 2023 08:12
@sgammon sgammon merged commit b93da33 into v3 Jul 26, 2023
@sgammon sgammon deleted the feat/url-intrinsic-null-port branch July 26, 2023 08:12
@sgammon sgammon mentioned this pull request Jul 27, 2023
37 tasks
@sgammon sgammon mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Features and issues relating to JS platform:jvm PRs and issues relating to JVM support.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant