Improved product URL error message to show which URLs were not unique #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjaap
reviewed
Dec 14, 2022
peterjaap
reviewed
Dec 14, 2022
|
Well whatthediff.ai wasn't any help with that :D So I added it manually. Thanks!! |
|
Awesome, thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the exception is of type
\Magento\UrlRewrite\Model\Exception\UrlAlreadyExistsException, we can actually get the list of URL rewrites that failed by calling itsgetUrlsmethod.I needed this for a project where I couldn't use the baldwin module because it doesn't show URL clashes between 301/302 URLs, product URLs and category URLs (I believe that it can only show duplicate URLs of a single entity type).
To be honest, the next catch clause can probably be dropped entirely. (I don't mind the initial exception being caught/processed by Symfony command.)
Also, it needs to be clear that even one error will cause the entire batch of ~500 URLs to be rolled back and fail. Maybe I could add that to the error msg?