Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edited request.get to wait indefinitely #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Edited request.get to wait indefinitely #20

wants to merge 1 commit into from

Conversation

CheoR
Copy link
Contributor

@CheoR CheoR commented Jan 17, 2015

Requests should now wait indefinitely.

@eleweek
Copy link
Owner

eleweek commented Jan 17, 2015

Are you sure it is good idea to wait that long? Maybe it is better to wait for something like 30-45 seconds?

@CheoR
Copy link
Contributor Author

CheoR commented Jan 17, 2015

Maybe chaning it to 30 seconds would be better, as per the requests website:

It’s a good practice to set connect timeouts to slightly larger than a multiple of 3, which is the default TCP packet retransmission window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CheoR @eleweek